Prev: [PATCH] um: Include missing header file in os-linux/mem.c
Next: [PATCH] use find_lock_task_mm in memory cgroups oom v2
From: Joel Becker on 15 Jun 2010 19:50
On Wed, May 26, 2010 at 05:58:53PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia(a)diku.dk>
>
> Add a spin_unlock missing on the error path. Unlock as in the other code
> that leads to the leave label.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression E1;
> @@
>
> * spin_lock(E1,...);
> <+... when != E1
> if (...) {
> ... when != E1
> * return ...;
> }
> ...+>
> * spin_unlock(E1,...);
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia(a)diku.dk>

This patch is now in the 'fixes' branch of ocfs2.git.

Joel

--

"In the arms of the angel, fly away from here,
From this dark, cold hotel room and the endlessness that you fear.
You are pulled from the wreckage of your silent reverie.
In the arms of the angel, may you find some comfort here."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker(a)oracle.com
Phone: (650) 506-8127
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] um: Include missing header file in os-linux/mem.c
Next: [PATCH] use find_lock_task_mm in memory cgroups oom v2