fs/ocfs2/dlm: Use kstrdup
in [Kernel]
|
Prev: [PATCH 29/37] swiotlb: Use page alignment for early buffer allocation
Next: security/selinux/ss: Use kstrdup
From: Joel Becker on 14 May 2010 16:10 On Fri, May 14, 2010 at 09:30:48PM +0200, Julia Lawall wrote: > From: Julia Lawall <julia(a)diku.dk> > > Use kstrdup when the goal of an allocation is copy a string into the > allocated region. Seems fine. I'll send it along. Joel -- "In the arms of the angel, fly away from here, From this dark, cold hotel room and the endlessness that you fear. You are pulled from the wreckage of your silent reverie. In the arms of the angel, may you find some comfort here." Joel Becker Principal Software Developer Oracle E-mail: joel.becker(a)oracle.com Phone: (650) 506-8127 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Joel Becker on 18 May 2010 15:40
On Fri, May 14, 2010 at 09:30:48PM +0200, Julia Lawall wrote: > From: Julia Lawall <julia(a)diku.dk> > > Use kstrdup when the goal of an allocation is copy a string into the > allocated region. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression from,to; > expression flag,E1,E2; > statement S; > @@ > > - to = kmalloc(strlen(from) + 1,flag); > + to = kstrdup(from, flag); > ... when != \(from = E1 \| to = E1 \) > if (to==NULL || ...) S > ... when != \(from = E2 \| to = E2 \) > - strcpy(to, from); > // </smpl> > > Signed-off-by: Julia Lawall <julia(a)diku.dk> This patch is now in the merge-window branch of ocfs2.git. Joel -- "If you are ever in doubt as to whether or not to kiss a pretty girl, give her the benefit of the doubt" -Thomas Carlyle Joel Becker Principal Software Developer Oracle E-mail: joel.becker(a)oracle.com Phone: (650) 506-8127 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |