Prev: [PATCH] extensions: libipt_CHECKSUM extension
Next: [PATCH 00/16] staging:ti dspbridge: Remove CamelCase, reagroup variables.
From: Jonathan Woithe on 8 Jul 2010 19:10
Looks fine to me.

Acked-by: Jonathan Woithe <jwoithe(a)physics.adelaide.edu.au>

> The following symbols are needlessly defined global:
>
> logolamp_led
> kblamps_led
>
> This patch makes the symbols static.
>
> Signed-off-by: Axel Lin <axel.lin(a)gmail.com>
> ---
> drivers/platform/x86/fujitsu-laptop.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index e325aeb..a758d59 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -182,7 +182,7 @@ static enum led_brightness logolamp_get(struct led_classdev *cdev);
> static void logolamp_set(struct led_classdev *cdev,
> enum led_brightness brightness);
>
> -struct led_classdev logolamp_led = {
> +static struct led_classdev logolamp_led = {
> .name = "fujitsu::logolamp",
> .brightness_get = logolamp_get,
> .brightness_set = logolamp_set
> @@ -192,7 +192,7 @@ static enum led_brightness kblamps_get(struct led_classdev *cdev);
> static void kblamps_set(struct led_classdev *cdev,
> enum led_brightness brightness);
>
> -struct led_classdev kblamps_led = {
> +static struct led_classdev kblamps_led = {
> .name = "fujitsu::kblamps",
> .brightness_get = kblamps_get,
> .brightness_set = kblamps_set
> --
> 1.5.4.3
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] extensions: libipt_CHECKSUM extension
Next: [PATCH 00/16] staging:ti dspbridge: Remove CamelCase, reagroup variables.