hstore ==> and deprecate =>
in [PgSql]
|
From: Merlin Moncure on 8 Jun 2010 15:34 On Tue, Jun 8, 2010 at 3:07 PM, Robert Haas <robertmhaas(a)gmail.com> wrote: > I believe that the consensus was mostly in favor of deprecating => as > an operator name, with the intent to abolish it completely in a future > release. �Attached is a patch to implement ==> as an alternative > operator name for hstore, and to make the backend throw a warning when > => is used as an operator name. > > One wart is that => is used not only as a SQL-level operator, but also > by hstore_in() when interpreting hstore-type literals, and by > hstore_out() when generating them. �My gut feeling is that we should > leave this part alone and only muck with the SQL operator, but perhaps > someone will care to argue the point. > > http://archives.postgresql.org/pgsql-hackers/2010-05/msg01501.php hm. any chance of a shorter operator, like '#'? I kinda agree that hstore_in and the operator don't have to be the same, but requiring three letter token for the two most high traffic operations w/hstore seems off to me. # is currently used for bitwise xor/geo merlin -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Robert Haas on 8 Jun 2010 15:38 On Tue, Jun 8, 2010 at 3:34 PM, Merlin Moncure <mmoncure(a)gmail.com> wrote: > On Tue, Jun 8, 2010 at 3:07 PM, Robert Haas <robertmhaas(a)gmail.com> wrote: >> I believe that the consensus was mostly in favor of deprecating => as >> an operator name, with the intent to abolish it completely in a future >> release. �Attached is a patch to implement ==> as an alternative >> operator name for hstore, and to make the backend throw a warning when >> => is used as an operator name. >> >> One wart is that => is used not only as a SQL-level operator, but also >> by hstore_in() when interpreting hstore-type literals, and by >> hstore_out() when generating them. �My gut feeling is that we should >> leave this part alone and only muck with the SQL operator, but perhaps >> someone will care to argue the point. >> >> http://archives.postgresql.org/pgsql-hackers/2010-05/msg01501.php > > hm. �any chance of a �shorter operator, like '#'? �I kinda agree that > hstore_in and the operator don't have to be the same, but requiring > three letter token for the two most high traffic operations w/hstore > seems off to me. > > # is currently used for bitwise xor/geo I'm happy to do whatever the consensus is. I thought it would be easier to remember if the two operators were spelled at least somewhat similarly, but I just work here. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Pavel Stehule on 8 Jun 2010 15:38 2010/6/8 Merlin Moncure <mmoncure(a)gmail.com>: > On Tue, Jun 8, 2010 at 3:07 PM, Robert Haas <robertmhaas(a)gmail.com> wrote: >> I believe that the consensus was mostly in favor of deprecating => as >> an operator name, with the intent to abolish it completely in a future >> release. Attached is a patch to implement ==> as an alternative >> operator name for hstore, and to make the backend throw a warning when >> => is used as an operator name. >> >> One wart is that => is used not only as a SQL-level operator, but also >> by hstore_in() when interpreting hstore-type literals, and by >> hstore_out() when generating them. My gut feeling is that we should >> leave this part alone and only muck with the SQL operator, but perhaps >> someone will care to argue the point. >> >> http://archives.postgresql.org/pgsql-hackers/2010-05/msg01501.php > > hm. any chance of a shorter operator, like '#'? I kinda agree that > hstore_in and the operator don't have to be the same, but requiring > three letter token for the two most high traffic operations w/hstore > seems off to me. I am for Robert's proposal - ===> is one char longer - but significantly readable Regards Pavel p.s. I hope so in 9.1 will be complete hstore module marked as deprecated > > # is currently used for bitwise xor/geo > > merlin > > -- > Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-hackers > -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Tom Lane on 8 Jun 2010 15:43 Pavel Stehule <pavel.stehule(a)gmail.com> writes: > p.s. I hope so in 9.1 will be complete hstore module marked as deprecated Really? And replaced with what? And why wouldn't the replacement use the same operator names? regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Andrew Dunstan on 8 Jun 2010 15:54
Tom Lane wrote: > Pavel Stehule <pavel.stehule(a)gmail.com> writes: > >> p.s. I hope so in 9.1 will be complete hstore module marked as deprecated >> > > Really? And replaced with what? And why wouldn't the replacement use > the same operator names? > > > Yeah. I'll be looking for throats to cut if that happens. I have several apps that use it extensively. If anything, I want it brought into core - it has wide ranging usefulness. cheers andrew -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |