i2c: cyttsp i2c and spi touchscreen driver init submit
in [Kernel]
|
Prev: drivers/media/video/bt8xx: Adjust confusing if indentation
Next: drivers/media/video/bt8xx: Adjust confusing if indentation
From: Henrik Rydberg on 6 Aug 2010 21:00 On 08/07/2010 02:32 AM, Kevin McNeely wrote: [...] > However, I would like to keep the MT Protocol A. Our solution allows > The platform builder to select to use MT protocol B or not as part of > platform_data in the board configuration. If it makes more sense, > I can reverse the code to default to protocol B and allow the platform > builder developer to select protocol A. There is nothing preventing you from keeping say a dkms package somewhere with all options intact. However, for the kernel, it is a question of maintainability. If the driver can produce prefectly valid data using protocol B, and by doing so several hundred lines of code can be removed, that is very much preferred. Since both protocols can be translated to protocol B via mtdev, which is already very much in use, there is little reason to support protocol A when the device can do tracking. Thanks, Henrik -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Kevin McNeely on 9 Aug 2010 21:00
Hi Henrik, > -----Original Message----- > From: Henrik Rydberg [mailto:rydberg(a)euromail.se] > Sent: Friday, August 06, 2010 5:49 PM > To: Kevin McNeely > Cc: Dmitry Torokhov; David Brown; Trilok Soni; Fred; Samuel Ortiz; Eric > Miao; Ben Dooks; Simtec Linux Team; Todd Fischer; Arnaud Patard; Sascha > Hauer; linux-input(a)vger.kernel.org; linux-kernel(a)vger.kernel.org > Subject: Re: [PATCH] i2c: cyttsp i2c and spi touchscreen driver init > submit > > On 08/07/2010 02:32 AM, Kevin McNeely wrote: > > [...] > > > However, I would like to keep the MT Protocol A. Our solution allows > > > The platform builder to select to use MT protocol B or not as part of > > platform_data in the board configuration. If it makes more sense, > > I can reverse the code to default to protocol B and allow the > platform > > builder developer to select protocol A. > > > There is nothing preventing you from keeping say a dkms package > somewhere with > all options intact. However, for the kernel, it is a question of > maintainability. If the driver can produce prefectly valid data using > protocol > B, and by doing so several hundred lines of code can be removed, that > is very > much preferred. Since both protocols can be translated to protocol B > via mtdev, > which is already very much in use, there is little reason to support > protocol A > when the device can do tracking. I will remove the Protocol A. Thank you again for your review. -kevin > > Thanks, > Henrik --------------------------------------------------------------- This message and any attachments may contain Cypress (or its subsidiaries) confidential information. If it has been received in error, please advise the sender and immediately delete this message. --------------------------------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |