Prev: [PATCH] perf: timechart: handle pthreads correctly
Next: [PATCH] USB: pxa27x_udc: use four bits to store endpoint addresses
From: Konrad Rzeszutek Wilk on 1 Apr 2010 16:30
On Wed, Mar 31, 2010 at 07:07:32PM -0700, Yinghai Lu wrote:
>
>
> So arch code could decide the way to reserve the ibft.
>
> And We should reserve ibft as early as possible, instead of BOOTMEM stage,
> in case the table is in RAM range and is not reserved by BIOS.

What test vehicle did you use to find this bug?


... snip..
> + if (size)
> + reserve_early_overlap_ok(addr, addr + size, "ifbt");
^^^^ - ibft

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Yinghai Lu on 1 Apr 2010 17:10
On 04/01/2010 01:12 PM, Konrad Rzeszutek Wilk wrote:
> On Wed, Mar 31, 2010 at 07:07:32PM -0700, Yinghai Lu wrote:
>>
>>
>> So arch code could decide the way to reserve the ibft.
>>
>> And We should reserve ibft as early as possible, instead of BOOTMEM stage,
>> in case the table is in RAM range and is not reserved by BIOS.
>
> What test vehicle did you use to find this bug?

code review for CONFIG_NO_BOOTMEM

reserve_bootmem() should only be used for converting entries reserved by reserved_early()

so When we are using CONFIG_NO_BOOTMEM, reserve_bootmem() is killed.

>
>
> .. snip..
>> + if (size)
>> + reserve_early_overlap_ok(addr, addr + size, "ifbt");
> ^^^^ - ibft
thanks, will change it.

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Konrad Rzeszutek Wilk on 8 Apr 2010 13:20
> > For all I know this is all perfectly fine, but I have _no_ idea about how
> > ibft is supposed to work, so I can't really judge it. As a result, I won't
> > pull it without some more acks from people who actually know what that
> > thing is..
>
> Oh, I am definitely ACK-ing. Sorry about not explicitly stating that.
> The developer is Yinghai Lu, I am the co-maintainer of the iBFT driver.
>
> Linus, would you like me to modify the commit so that it has 'Acked-by:'
> by me in the git tree?

I've gone ahead and done that. The git tree:

git://git.kernel.org/pub/scm/linux/kernel/git/konrad/ibft-2.6.git
ibft-fixes.acked

has the patch that was acked (and reviewed + tested on my iBFT rig)
by me.

(The ibft-fixes has the old commit, with the Signed-off-by instead of
Acked-by).

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] perf: timechart: handle pthreads correctly
Next: [PATCH] USB: pxa27x_udc: use four bits to store endpoint addresses