Prev: input: Tone down logging from S3C touchscreen driver
Next: [Regression] [2.6.35-rc1] ssb_is_sprom_available
From: Dmitry Torokhov on 31 May 2010 15:20
On Mon, May 31, 2010 at 02:02:15PM +0200, Dan Carpenter wrote:
> This patch silences a sparse warning:
>
> drivers/input/touchscreen/tps6507x-ts.c:345:19:
> warning: Using plain integer as NULL pointer
> drivers/input/touchscreen/tps6507x-ts.c:367:19:
> warning: Using plain integer as NULL pointer
>
> Signed-off-by: Dan Carpenter <error27(a)gmail.com>
>
> diff --git a/drivers/input/touchscreen/tps6507x-ts.c b/drivers/input/touchscreen/tps6507x-ts.c
> index b99db09..1e57e4e 100644
> --- a/drivers/input/touchscreen/tps6507x-ts.c
> +++ b/drivers/input/touchscreen/tps6507x-ts.c
> @@ -342,7 +342,7 @@ err2:
> cancel_delayed_work(&tsc->work);
> flush_workqueue(tsc->wq);
> destroy_workqueue(tsc->wq);
> - tsc->wq = 0;
> + tsc->wq = NULL;
> input_free_device(input_dev);
> err1:
> kfree(tsc);
> @@ -364,7 +364,7 @@ static int __devexit tps6507x_ts_remove(struct platform_device *pdev)
> cancel_delayed_work(&tsc->work);
> flush_workqueue(tsc->wq);

Why isn't it cancel_delayed_work_sync()?

> destroy_workqueue(tsc->wq);
> - tsc->wq = 0;
> + tsc->wq = NULL;
>

Setting tsc to 0/NULL does not make much sense as it is being freed a
couple of lines below.

> input_free_device(input_dev);
>

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Dan Carpenter on 31 May 2010 17:10
On Mon, May 31, 2010 at 12:10:29PM -0700, Dmitry Torokhov wrote:
> On Mon, May 31, 2010 at 02:02:15PM +0200, Dan Carpenter wrote:
> > --- a/drivers/input/touchscreen/tps6507x-ts.c
> > +++ b/drivers/input/touchscreen/tps6507x-ts.c
> > @@ -342,7 +342,7 @@ err2:
> > cancel_delayed_work(&tsc->work);
> > flush_workqueue(tsc->wq);
> > destroy_workqueue(tsc->wq);
> > - tsc->wq = 0;
> > + tsc->wq = NULL;
> > input_free_device(input_dev);
> > err1:
> > kfree(tsc);
> > @@ -364,7 +364,7 @@ static int __devexit tps6507x_ts_remove(struct platform_device *pdev)
> > cancel_delayed_work(&tsc->work);
> > flush_workqueue(tsc->wq);
>
> Why isn't it cancel_delayed_work_sync()?
>

Good point.

> > destroy_workqueue(tsc->wq);
> > - tsc->wq = 0;
> > + tsc->wq = NULL;
> >
>
> Setting tsc to 0/NULL does not make much sense as it is being freed a
> couple of lines below.
>

That's true. I'll send an updated patch tomorrow.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: input: Tone down logging from S3C touchscreen driver
Next: [Regression] [2.6.35-rc1] ssb_is_sprom_available