From: jidanni on
In /etc/grub.d/00_header we see

transform="s,x,x,"
grub_prefix=`echo /boot/grub | sed ${transform}`
locale_dir=`echo /boot/grub/locale | sed ${transform}`

Isn't that sed line one big no-op?
Should I file a bug to have it removed or at least have a comment added
as to its purpose, or have them use a better way to achieve what they
are trying to do?


--
To UNSUBSCRIBE, email to debian-user-REQUEST(a)lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster(a)lists.debian.org
Archive: http://lists.debian.org/877hnh6eco.fsf(a)jidanni.org
From: Andrew Sackville-West on
On Thu, May 06, 2010 at 08:52:39AM +0800, jidanni(a)jidanni.org wrote:
> In /etc/grub.d/00_header we see
>
> transform="s,x,x,"
> grub_prefix=`echo /boot/grub | sed ${transform}`
> locale_dir=`echo /boot/grub/locale | sed ${transform}`
>
> Isn't that sed line one big no-op?

looks like it to me.

> Should I file a bug to have it removed or at least have a comment added
> as to its purpose, or have them use a better way to achieve what they
> are trying to do?

maybe a question is better than a bug report. I imagine it's just a
convenience variable in case someone needs to transform paths for some
reason.

A
From: Teemu Likonen on
* 2010-05-06 08:52 (+0800), jidanni(a)jidanni.org wrote:

> In /etc/grub.d/00_header we see
>
> transform="s,x,x,"
> grub_prefix=`echo /boot/grub | sed ${transform}`
> locale_dir=`echo /boot/grub/locale | sed ${transform}`
>
> Isn't that sed line one big no-op? Should I file a bug to have it
> removed or at least have a comment added as to its purpose, or have
> them use a better way to achieve what they are trying to do?

I'm sure it's for a purpose. If you file a bug I'd suggest a wish list
category and tone like "Please document the purpose of ..."

--
Feel free to Cc me your replies if you want to make sure I'll notice
them. I can't read all the list mail.


--
To UNSUBSCRIBE, email to debian-user-REQUEST(a)lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster(a)lists.debian.org
Archive: http://lists.debian.org/87zl0d7li1.fsf(a)mithlond.arda
From: Sven Joachim on
On 2010-05-06 05:23 +0200, Andrew Sackville-West wrote:

> On Thu, May 06, 2010 at 08:52:39AM +0800, jidanni(a)jidanni.org wrote:
>> In /etc/grub.d/00_header we see
>>
>> transform="s,x,x,"
>> grub_prefix=`echo /boot/grub | sed ${transform}`
>> locale_dir=`echo /boot/grub/locale | sed ${transform}`
>>
>> Isn't that sed line one big no-op?
>
> looks like it to me.
>
>> Should I file a bug to have it removed or at least have a comment added
>> as to its purpose, or have them use a better way to achieve what they
>> are trying to do?
>
> maybe a question is better than a bug report. I imagine it's just a
> convenience variable in case someone needs to transform paths for some
> reason.

Yes, actually you can do it at build time by using the configure option
--program-transform-name. Say you want grub to be named grub2 to
distinguish it from grub-legacy, then you can run

$ ./configure --program-transform-name=s/grub/grub2/

and 00_header will have the transform line look like this

transform="s/grub/grub2/"

This somewhat obscure feature is not used in the Debian package,
hence the no-ops.

Sven


--
To UNSUBSCRIBE, email to debian-user-REQUEST(a)lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster(a)lists.debian.org
Archive: http://lists.debian.org/87tyqlo4a1.fsf(a)turtle.gmx.de
From: jidanni on
>>>>> "SJ" == Sven Joachim <svenjoac(a)gmx.de> writes:

SJ> Yes, actually you can do it at build time by using the configure option
SJ> --program-transform-name. Say you want grub to be named grub2 to
SJ> distinguish it from grub-legacy, then you can run

SJ> $ ./configure --program-transform-name=s/grub/grub2/

SJ> and 00_header will have the transform line look like this

SJ> transform="s/grub/grub2/"

SJ> This somewhat obscure feature is not used in the Debian package,
SJ> hence the no-ops.

Hmmm, then there is a bug in whatever preprocessor package they are
using, that leaves such confusing no-ops when in fact nothing should be
left at all perhaps...


--
To UNSUBSCRIBE, email to debian-user-REQUEST(a)lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster(a)lists.debian.org
Archive: http://lists.debian.org/87wrvg1253.fsf(a)jidanni.org