iwlwifi: range checking issue
in [Kernel]
|
Prev: revert request "ide: skip probe if there are no devices on the port (v2)"
Next: fault while using perf callchains in sparc64
From: Zhu Yi on 28 Mar 2010 22:10 On Sun, 2010-03-28 at 19:55 +0800, Dan Carpenter wrote: > IWL_RATE_COUNT is 13 and IWL_RATE_COUNT_LEGACY is 12. > > IWL_RATE_COUNT_LEGACY is the right one here because iwl3945_rates > doesn't support 60M and also that's how "rates" is defined in > iwlcore_init_geos() from drivers/net/wireless/iwlwifi/iwl-core.c. > > rates = kzalloc((sizeof(struct ieee80211_rate) * IWL_RATE_COUNT_LEGACY), > GFP_KERNEL); > > Signed-off-by: Dan Carpenter <error27(a)gmail.com> Acked-by: Zhu Yi <yi.zhu(a)intel.com> Thanks, -yi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: reinette chatre on 29 Mar 2010 12:20
On Sun, 2010-03-28 at 19:01 -0700, Zhu, Yi wrote: > On Sun, 2010-03-28 at 19:55 +0800, Dan Carpenter wrote: > > IWL_RATE_COUNT is 13 and IWL_RATE_COUNT_LEGACY is 12. > > > > IWL_RATE_COUNT_LEGACY is the right one here because iwl3945_rates > > doesn't support 60M and also that's how "rates" is defined in > > iwlcore_init_geos() from drivers/net/wireless/iwlwifi/iwl-core.c. > > > > rates = kzalloc((sizeof(struct ieee80211_rate) * IWL_RATE_COUNT_LEGACY), > > GFP_KERNEL); > > > > Signed-off-by: Dan Carpenter <error27(a)gmail.com> > > Acked-by: Zhu Yi <yi.zhu(a)intel.com> Great catch. Since this is a fix for a buffer overflow ... could you please pass it on to stable also? Thank you Reinette -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |