kconfig: print symbol type in help text
in [Kernel]
|
Prev: lockdep: Fix redundant_hardirqs_on incremented with irqs enabled
Next: [PATCH 3/6] gconfig: fix to tag NEW symbols correctly
From: Li Zefan on 27 Apr 2010 03:50 [PATCH 2/6] menuconfig: improive help text a bit Suggested-by: Randy Dunlap <randy.dunlap(a)oracle.com> Signed-off-by: Li Zefan <lizf(a)cn.fujitsu.com> --- scripts/kconfig/mconf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c index 33f31eb..7ca6e8e 100644 --- a/scripts/kconfig/mconf.c +++ b/scripts/kconfig/mconf.c @@ -74,7 +74,7 @@ static const char mconf_readme[] = N_( "\n" " Shortcut: Press <H> or <?>.\n" "\n" -"o To show hidden options, press <Z>.\n" +"o To toggle the display of hidden options, press <Z>.\n" "\n" "\n" "Radiolists (Choice lists)\n" -- 1.6.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Randy Dunlap on 27 Apr 2010 16:40 On Tue, 27 Apr 2010 15:48:16 +0800 Li Zefan wrote: > Randy suggested to print out the symbol type in gconfig. > > Note this change does more than Randy's suggestion, that it also > affects the display of help text in other config tools. > > │ Symbol: BLOCK [=y] > │ Type : boolean > │ Prompt: Enable the block layer > │ Defined at block/Kconfig:4 > │ Depends on: EMBEDDED [=n] > > Signed-off-by: Li Zefan <lizf(a)cn.fujitsu.com> Acked-by: Randy Dunlap <randy.dunlap(a)oracle.com> Thanks. > --- > scripts/kconfig/menu.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c > index e150176..b5d15fa 100644 > --- a/scripts/kconfig/menu.c > +++ b/scripts/kconfig/menu.c > @@ -501,9 +501,11 @@ void get_symbol_str(struct gstr *r, struct symbol *sym) > bool hit; > struct property *prop; > > - if (sym && sym->name) > + if (sym && sym->name) { > str_printf(r, "Symbol: %s [=%s]\n", sym->name, > sym_get_string_value(sym)); > + str_printf(r, "Type : %s\n", sym_type_name(sym->type)); > + } > for_all_prompts(sym, prop) > get_prompt_str(r, prop); > hit = false; > -- > 1.6.3 --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Li Zefan on 14 May 2010 03:00 Hi Michal, what do you think about those patches? Seems Randy has had no further comments on them. Li Zefan wrote: > Randy suggested to print out the symbol type in gconfig. > > Note this change does more than Randy's suggestion, that it also > affects menuconfig and "make config". > > │ Symbol: BLOCK [=y] > │ Type : boolean > │ Prompt: Enable the block layer > │ Defined at block/Kconfig:4 > │ Depends on: EMBEDDED [=n] > > Signed-off-by: Li Zefan <lizf(a)cn.fujitsu.com> > Acked-by: Randy Dunlap <randy.dunlap(a)oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Michal Marek on 14 May 2010 16:50 On 14.5.2010 08:57, Li Zefan wrote: > Hi Michal, what do you think about those patches? Seems > Randy has had no further comments on them. Sorry, I've been quite busy this week due to a new arrival in our family. The patches are ok, thank you for your work and Randy for his review! I'll apply them. Michal > > Li Zefan wrote: >> Randy suggested to print out the symbol type in gconfig. >> >> Note this change does more than Randy's suggestion, that it also >> affects menuconfig and "make config". >> >> │ Symbol: BLOCK [=y] >> │ Type : boolean >> │ Prompt: Enable the block layer >> │ Defined at block/Kconfig:4 >> │ Depends on: EMBEDDED [=n] >> >> Signed-off-by: Li Zefan <lizf(a)cn.fujitsu.com> >> Acked-by: Randy Dunlap <randy.dunlap(a)oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Li Zefan on 16 May 2010 22:20
>> Hi Michal, what do you think about those patches? Seems >> Randy has had no further comments on them. > > Sorry, I've been quite busy this week due to a new arrival in our Congratulation! > family. The patches are ok, thank you for your work and Randy for his > review! I'll apply them. Thanks! And take your time. :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |