From: Catalin Marinas on 15 Jul 2010 11:10 On Wed, 2010-07-14 at 10:55 +0100, Pekka Enberg wrote: > Catalin Marinas wrote: > > On Wed, 2010-07-14 at 09:27 +0100, Zeno Davatz wrote: > >> On Wed, Jul 14, 2010 at 10:05 AM, Pekka Enberg <penberg(a)cs.helsinki.fi> wrote: > >>> On Wed, Jul 14, 2010 at 9:12 AM, Zeno Davatz <zdavatz(a)gmail.com> wrote: > > > >>>> I am attaching you the file from /sys/kernel/debug/kmemleak > >>> Zeno, can you post your dmesg and .config, please? > >> Sure, see attached files. > > > > It looks like NO_BOOTMEM is enabled. You can try the attached patch (I > > need to post it again on the list). > > > > > > kmemleak: Add support for NO_BOOTMEM configurations > > > > From: Catalin Marinas <catalin.marinas(a)arm.com> > > > > With commits 08677214 and 59be5a8e, alloc_bootmem()/free_bootmem() and > > friends use the early_res functions for memory management when > > NO_BOOTMEM is enabled. This patch adds the kmemleak calls in the > > corresponding code paths for bootmem allocations. > > > > Signed-off-by: Catalin Marinas <catalin.marinas(a)arm.com> > > Cc: Yinghai Lu <yinghai(a)kernel.org> > > Cc: H. Peter Anvin <hpa(a)zytor.com> > > Makes sense. > > Acked-by: Pekka Enberg <penberg(a)cs.helsinki.fi> I'll post an updated patch since I missed a callback. I've been testing it since yesterday and seems ok. Thanks. -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Zeno Davatz on 15 Jul 2010 11:20 Dear Catalin On Thu, Jul 15, 2010 at 4:58 PM, Catalin Marinas <catalin.marinas(a)arm.com> wrote: > On Wed, 2010-07-14 at 10:55 +0100, Pekka Enberg wrote: >> Catalin Marinas wrote: >> > On Wed, 2010-07-14 at 09:27 +0100, Zeno Davatz wrote: >> >> On Wed, Jul 14, 2010 at 10:05 AM, Pekka Enberg <penberg(a)cs.helsinki.fi> wrote: >> >>> On Wed, Jul 14, 2010 at 9:12 AM, Zeno Davatz <zdavatz(a)gmail.com> wrote: >> > >> >>>> I am attaching you the file from /sys/kernel/debug/kmemleak >> >>> Zeno, can you post your dmesg and .config, please? >> >> Sure, see attached files. >> > >> > It looks like NO_BOOTMEM is enabled. You can try the attached patch (I >> > need to post it again on the list). >> > >> > >> > kmemleak: Add support for NO_BOOTMEM configurations >> > >> > From: Catalin Marinas <catalin.marinas(a)arm.com> >> > >> > With commits 08677214 and 59be5a8e, alloc_bootmem()/free_bootmem() and >> > friends use the early_res functions for memory management when >> > NO_BOOTMEM is enabled. This patch adds the kmemleak calls in the >> > corresponding code paths for bootmem allocations. >> > >> > Signed-off-by: Catalin Marinas <catalin.marinas(a)arm.com> >> > Cc: Yinghai Lu <yinghai(a)kernel.org> >> > Cc: H. Peter Anvin <hpa(a)zytor.com> >> >> Makes sense. >> >> Acked-by: Pekka Enberg <penberg(a)cs.helsinki.fi> > > I'll post an updated patch since I missed a callback. I've been testing > it since yesterday and seems ok. I also did not have anymore hangs and random bad moods of my CPUs that all of a sudden grab 100% of all 8 cores of my CPU power across my machine since I disabled CONFIG_NO_BOOTMEM: Best Zeno -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Pekka Enberg on 15 Jul 2010 12:00 Zeno Davatz wrote: > Dear Catalin > > On Thu, Jul 15, 2010 at 4:58 PM, Catalin Marinas > <catalin.marinas(a)arm.com> wrote: >> On Wed, 2010-07-14 at 10:55 +0100, Pekka Enberg wrote: >>> Catalin Marinas wrote: >>>> On Wed, 2010-07-14 at 09:27 +0100, Zeno Davatz wrote: >>>>> On Wed, Jul 14, 2010 at 10:05 AM, Pekka Enberg <penberg(a)cs.helsinki.fi> wrote: >>>>>> On Wed, Jul 14, 2010 at 9:12 AM, Zeno Davatz <zdavatz(a)gmail.com> wrote: >>>>>>> I am attaching you the file from /sys/kernel/debug/kmemleak >>>>>> Zeno, can you post your dmesg and .config, please? >>>>> Sure, see attached files. >>>> It looks like NO_BOOTMEM is enabled. You can try the attached patch (I >>>> need to post it again on the list). >>>> >>>> >>>> kmemleak: Add support for NO_BOOTMEM configurations >>>> >>>> From: Catalin Marinas <catalin.marinas(a)arm.com> >>>> >>>> With commits 08677214 and 59be5a8e, alloc_bootmem()/free_bootmem() and >>>> friends use the early_res functions for memory management when >>>> NO_BOOTMEM is enabled. This patch adds the kmemleak calls in the >>>> corresponding code paths for bootmem allocations. >>>> >>>> Signed-off-by: Catalin Marinas <catalin.marinas(a)arm.com> >>>> Cc: Yinghai Lu <yinghai(a)kernel.org> >>>> Cc: H. Peter Anvin <hpa(a)zytor.com> >>> Makes sense. >>> >>> Acked-by: Pekka Enberg <penberg(a)cs.helsinki.fi> >> I'll post an updated patch since I missed a callback. I've been testing >> it since yesterday and seems ok. > > I also did not have anymore hangs and random bad moods of my CPUs that > all of a sudden grab 100% of all 8 cores of my CPU power across my > machine since I disabled > > CONFIG_NO_BOOTMEM: Interesting. Damien, does disabling CONFIG_NO_BOOTMEM fix you problem too? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Damien Wyart on 15 Jul 2010 12:30 Hello, > > I also did not have anymore hangs and random bad moods of my CPUs > > that all of a sudden grab 100% of all 8 cores of my CPU power across > > my machine since I disabled > > CONFIG_NO_BOOTMEM: * Pekka Enberg <penberg(a)cs.helsinki.fi> [2010-07-15 18:54]: > Interesting. Damien, does disabling CONFIG_NO_BOOTMEM fix you problem too? I will test in the coming hours, and report back tomorrow... Just recompiled 2.6.35-rc5-git1 with this option disabled. -- Damien -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Damien Wyart on 15 Jul 2010 15:20
> > > I also did not have anymore hangs and random bad moods of my CPUs > > > that all of a sudden grab 100% of all 8 cores of my CPU power across > > > my machine since I disabled > > > CONFIG_NO_BOOTMEM: > * Pekka Enberg <penberg(a)cs.helsinki.fi> [2010-07-15 18:54]: > > Interesting. Damien, does disabling CONFIG_NO_BOOTMEM fix you problem too? > I will test in the coming hours, and report back tomorrow... Just > recompiled 2.6.35-rc5-git1 with this option disabled. For now, I can't reproduce the problem with CONFIG_NO_BOOTMEM disabled ; with the option and rc5 the problem was happening quite quickly after boot and normal use of the machine. So it seems I can confirme what Zeno has seen and I hope this will give a hint to debug the problem. I guess this has not been reported that much because many testers might not have enabled CONFIG_NO_BOOTMEM... Maybe the scheduler folks could test their benchmark with a kernel having this option enabled? -- Damien -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |