krb_server_keyfile setting doesn't work on Windows
in [PgSql]
|
From: Tom Lane on 30 Dec 2009 11:10 Hiroshi Inoue <inoue(a)tpf.co.jp> writes: > Because gssapi32.dll(krb5_32.dll) seems to call > getenv("KRB5_KTNAME") in msvcr71, postgres.exe > should call putenv("KRB5_KTNAME=...") in msvcr71. > The attached patch fixes the problem in my test > case. Don't we already have something like that in our src/port putenv substitute? regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Magnus Hagander on 30 Dec 2009 11:20 2009/12/30 Hiroshi Inoue <inoue(a)tpf.co.jp>: > Hi, > > As far as I tested, the krb_server_keyfile setting > in postgres.conf doesn't work on Windows. > > Because gssapi32.dll(krb5_32.dll) seems to call > getenv("KRB5_KTNAME") in msvcr71, postgres.exe > should call putenv("KRB5_KTNAME=...") in msvcr71. > The attached patch fixes the problem in my test > case. Isn't the main backend linked with msvcr71.dll anyway? Then the regular putenv should put it in th eenv of msvcr71.dll, and the stuff that's wrapped through src/port/win32env.c will put it in the regular msvcr file. I wonder if you're possibly being hit with the bug I patched the other day, but didn't backpatch. (http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=f8bcd7220b1166f7c037ceaf0a53958cbc6a7630). Can you see if that fix solves your problem as well? (Either directly or by testing HEAD) If not, the fix should still go in win32env.c, not directly in auth.c -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Hiroshi Inoue on 30 Dec 2009 17:50 Tom Lane wrote: > Hiroshi Inoue <inoue(a)tpf.co.jp> writes: >> Because gssapi32.dll(krb5_32.dll) seems to call >> getenv("KRB5_KTNAME") in msvcr71, postgres.exe >> should call putenv("KRB5_KTNAME=...") in msvcr71. >> The attached patch fixes the problem in my test >> case. > > Don't we already have something like that in our src/port putenv > substitute? Yes, pgwin32_putenv() calls putenv() in msvcrt which libintl or other MINGW dlls use. I'm not sure if it's appropriate to add msvcr71's putenv call to pgwin32_putenv() (src/port/win32env.c). regards, Hiroshi Inoue -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Hiroshi Inoue on 30 Dec 2009 18:55 Magnus Hagander wrote: > 2009/12/30 Hiroshi Inoue <inoue(a)tpf.co.jp>: >> Hi, >> >> As far as I tested, the krb_server_keyfile setting >> in postgres.conf doesn't work on Windows. >> >> Because gssapi32.dll(krb5_32.dll) seems to call >> getenv("KRB5_KTNAME") in msvcr71, postgres.exe >> should call putenv("KRB5_KTNAME=...") in msvcr71. >> The attached patch fixes the problem in my test >> case. > > Isn't the main backend linked with msvcr71.dll anyway? What main backend directly links is msvcr80 or msvcr90 according to the msvc build environment. > Then the > regular putenv should put it in th eenv of msvcr71.dll, and the stuff > that's wrapped through src/port/win32env.c will put it in the regular > msvcr file. > > I wonder if you're possibly being hit with the bug I patched the other > day, but didn't backpatch. > (http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=f8bcd7220b1166f7c037ceaf0a53958cbc6a7630). > > Can you see if that fix solves your problem as well? (Either directly > or by testing HEAD) I'm testing using the current cvs. > If not, the fix should still go in win32env.c, not directly in auth.c I don't object to it. Possibly we would have to add msvcr80 or msvcr90 as well in the future. regards, Hiroshi Inoue -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Magnus Hagander on 30 Dec 2009 18:57 2009/12/31 Hiroshi Inoue <inoue(a)tpf.co.jp>: > Magnus Hagander wrote: >> >> 2009/12/30 Hiroshi Inoue <inoue(a)tpf.co.jp>: >>> >>> Hi, >>> >>> As far as I tested, the krb_server_keyfile setting >>> in postgres.conf doesn't work on Windows. >>> >>> Because gssapi32.dll(krb5_32.dll) seems to call >>> getenv("KRB5_KTNAME") in msvcr71, postgres.exe >>> should call putenv("KRB5_KTNAME=...") in msvcr71. >>> The attached patch fixes the problem in my test >>> case. >> >> Isn't the main backend linked with msvcr71.dll anyway? > > What main backend directly links is msvcr80 or msvcr90 > according to the msvc build environment. Arrgh. My bad, I thought msvcr71 was vs2005. Now that you put it like this, I know it's vs2003. >> Then the >> regular putenv should put it in th eenv of msvcr71.dll, and the stuff >> that's wrapped through src/port/win32env.c will put it in the regular >> msvcr file. >> >> I wonder if you're possibly being hit with the bug I patched the other >> day, but didn't backpatch. >> (http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=f8bcd7220b1166f7c037ceaf0a53958cbc6a7630). >> >> Can you see if that fix solves your problem as well? (Either directly >> or by testing HEAD) > > I'm testing using the current cvs. > >> If not, the fix should still go in win32env.c, not directly in auth.c > > I don't object to it. Possibly we would have to add msvcr80 or > msvcr90 as well in the future. To be safe, yes, we should have that. Do you want to work on such a complete solution, or should I look at it? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
|
Next
|
Last
Pages: 1 2 Prev: solution to make static changes in pg_hba.conf file? Next: [HACKERS] Thread safety and libxml2 |