Prev: [freebsd-ports] Pilot error or bash dependencies broken?
Next: Why do ports tree have two neon ports?
From: Scot Hetzel on 17 Mar 2010 23:50
On Wed, Mar 17, 2010 at 9:35 PM, Jason Garrett <kingedgar(a)gmail.com> wrote:
> The port now compiles.
>
> I could submit a patch omitting this, but is that the RIGHT fix?

The correct fix is to remove the sys/timeb.h from the list of headers
to check for in the configure.in script

See PR 144845

http://www.freebsd.org/cgi/query-pr.cgi?pr=144845

Scot
_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"

From: Scot Hetzel on 17 Mar 2010 23:55
On Wed, Mar 17, 2010 at 10:45 PM, Adam Vande More <amvandemore(a)gmail.com> wrote:
> On Wed, Mar 17, 2010 at 10:38 PM, Jason Garrett <kingedgar(a)gmail.com> wrote:
>
>> CC'ing port maintainer
>>
>> Here is the commit for timeb.h being deprecated and adding the #warning
>>
>> http://www.mail-archive.com/svn-src-all(a)freebsd.org/msg20965.html
>>
>> Solutions are to either use a replacement for timeb.h (unknown by me
>> at this point), quit using timeb.h (not sure how guile depends on
>> this), or omit the -Werror from
>> /usr/ports/lang/guile/work/guile-1.8.6/Makefile and
>> /usr/ports/lang/guile-1.8.6/libguile/Makefile.
>>
>> Maintainer, please direct on how to proceed. As it sits without
>> modification the port is broken, even with -Wno-error set in
>> /etc/make.conf.
>>
>
> I'm not sure about that.  The no-error stuff I believe is a CURRENT thing,
> at least when running betas and stuff you'll run into the warnings as errors
> thing.  The port builds fine on other branches and I suspect would continue
> to build on CURRENT if you got rid of whatever controlling the compile
> setting.  Nevertheless, it seems the port should be fixed to use sys/time.h
> and gettimeofday(2) instead.  Just the way it looks to me, I'm no expert
> here.
>
The port only uses sys/timeb.h in libguile/stime.c, and only to
include the header when HAVE_SYS_TIMEB_H is defined, removing
sys/timeb.h from the header include check in configure.in allows the
port to build on a recent CURRENT.

Scot
_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"

From: Jason Garrett on 17 Mar 2010 23:58
On Wed, Mar 17, 2010 at 22:55, Scot Hetzel <swhetzel(a)gmail.com> wrote:
> On Wed, Mar 17, 2010 at 10:45 PM, Adam Vande More <amvandemore(a)gmail.com> wrote:
>> On Wed, Mar 17, 2010 at 10:38 PM, Jason Garrett <kingedgar(a)gmail.com> wrote:
>>
>>> CC'ing port maintainer
>>>
>>> Here is the commit for timeb.h being deprecated and adding the #warning
>>>
>>> http://www.mail-archive.com/svn-src-all(a)freebsd.org/msg20965.html
>>>
>>> Solutions are to either use a replacement for timeb.h (unknown by me
>>> at this point), quit using timeb.h (not sure how guile depends on
>>> this), or omit the -Werror from
>>> /usr/ports/lang/guile/work/guile-1.8.6/Makefile and
>>> /usr/ports/lang/guile-1.8.6/libguile/Makefile.
>>>
>>> Maintainer, please direct on how to proceed. As it sits without
>>> modification the port is broken, even with -Wno-error set in
>>> /etc/make.conf.
>>>
>>
>> I'm not sure about that.  The no-error stuff I believe is a CURRENT thing,
>> at least when running betas and stuff you'll run into the warnings as errors
>> thing.  The port builds fine on other branches and I suspect would continue
>> to build on CURRENT if you got rid of whatever controlling the compile
>> setting.  Nevertheless, it seems the port should be fixed to use sys/time.h
>> and gettimeofday(2) instead.  Just the way it looks to me, I'm no expert
>> here.
>>
> The port only uses sys/timeb.h in libguile/stime.c, and only to
> include the header when HAVE_SYS_TIMEB_H is defined, removing
> sys/timeb.h from the header include check in configure.in allows the
> port to build on a recent CURRENT.
>
> Scot
>

Thank you for your response, I learn more each time I post to these lists!
_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"

From: Adam Vande More on 18 Mar 2010 00:00
On Wed, Mar 17, 2010 at 10:55 PM, Scot Hetzel <swhetzel(a)gmail.com> wrote:

> On Wed, Mar 17, 2010 at 10:45 PM, Adam Vande More <amvandemore(a)gmail.com>
> wrote:
> > On Wed, Mar 17, 2010 at 10:38 PM, Jason Garrett <kingedgar(a)gmail.com>
> wrote:
> >
> >> CC'ing port maintainer
> >>
> >> Here is the commit for timeb.h being deprecated and adding the #warning
> >>
> >> http://www.mail-archive.com/svn-src-all(a)freebsd.org/msg20965.html
> >>
> >> Solutions are to either use a replacement for timeb.h (unknown by me
> >> at this point), quit using timeb.h (not sure how guile depends on
> >> this), or omit the -Werror from
> >> /usr/ports/lang/guile/work/guile-1.8.6/Makefile and
> >> /usr/ports/lang/guile-1.8.6/libguile/Makefile.
> >>
> >> Maintainer, please direct on how to proceed. As it sits without
> >> modification the port is broken, even with -Wno-error set in
> >> /etc/make.conf.
> >>
> >
> > I'm not sure about that. The no-error stuff I believe is a CURRENT
> thing,
> > at least when running betas and stuff you'll run into the warnings as
> errors
> > thing. The port builds fine on other branches and I suspect would
> continue
> > to build on CURRENT if you got rid of whatever controlling the compile
> > setting. Nevertheless, it seems the port should be fixed to use
> sys/time.h
> > and gettimeofday(2) instead. Just the way it looks to me, I'm no expert
> > here.
> >
> The port only uses sys/timeb.h in libguile/stime.c, and only to
> include the header when HAVE_SYS_TIMEB_H is defined, removing
> sys/timeb.h from the header include check in configure.in allows the
> port to build on a recent CURRENT.
>
> Scot
>



--
Adam Vande More
_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"

From: Doug Barton on 18 Mar 2010 03:48
On Wed, 17 Mar 2010, Chuck Swiger wrote:

> touch /etc/make.conf && echo "CFLAGS += -Wno-error" >> /etc/make.conf

No reason for the touch first, FWIW.


Doug

--

Improve the effectiveness of your Internet presence with
a domain name makeover! http://SupersetSolutions.com/

Computers are useless. They can only give you answers.
-- Pablo Picasso

_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"

First  |  Prev  |  Next  |  Last
Pages: 1 2 3 4
Prev: [freebsd-ports] Pilot error or bash dependencies broken?
Next: Why do ports tree have two neon ports?