libata: pass host flags into __ata_pci_sff_init_one() helper
in [Kernel]
|
Prev: cpuset,mm: update tasks' mems_allowed in time (58568d2)
Next: [PATCH -tip v10 5/9] kprobes/x86: Boost probes when reentering
From: Alan Cox on 18 Feb 2010 16:50 On Thu, 18 Feb 2010 19:59:22 +0100 Bartlomiej Zolnierkiewicz <bzolnier(a)gmail.com> wrote: > From: Bartlomiej Zolnierkiewicz <bzolnier(a)gmail.com> > Subject: [PATCH] libata: pass host flags into __ata_pci_sff_init_one() helper > > This was orginally proposed by Alan Cox but as a change > for ata_pci_sff_init_one() helper function instead of > __ata_pci_sff_init_one() one which casues needless churn > to all host drivers and accidentally breakes few host > drivers which are still on their way upstream. > > Allows parallel scan and the like to be set without > having to stop using the existing full helper functions. NAK - __ is for internal symbol names. I was split 50/50 on adding ata_pci_sff_init_one_flags() or similar but the churn, given its a one off and we can then add all sorts of other future flags without pain, seemed worth it. I'm ambivalent about whether its best to go with a new function name as you have or take the hit now (which seems sensible to me). Either way the __ naming is wrong for an external interface. Anyway I'd *hope* we can get > 50% of interfaces parallel scanning at which point it ceases to be more noise anyway ! Jeff ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Alan Cox on 18 Feb 2010 18:30
> - __ has been also used for exactly such purpose in the kernel, i.e.: As helpers for inlines and like the yes... Matter of style anyway. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |