From: Randy Dunlap on
On 02/15/10 00:49, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20100212:


1/ dt3155 tries to use arbitrary divide & modulus. This fails on i386:

ERROR: "__udivdi3" [drivers/staging/dt3155/dt3155.ko] undefined!
ERROR: "__umoddi3" [drivers/staging/dt3155/dt3155.ko] undefined!

2/ since DT3155 depends on PCI, these lines can be dropped from dt3155_drv.c:

-#ifndef CONFIG_PCI
-#error "DT3155 : Kernel PCI support not enabled (DT3155 drive requires PCI)"
-#endif

3/ header files need to be included even when built-in instead of defined(MODULE)
to eliminate build errors:

drivers/staging/dt3155/dt3155_drv.c:1047: error: implicit declaration of function 'request_irq'
drivers/staging/dt3155/dt3155_drv.c:1048: error: 'IRQF_SHARED' undeclared (first use in this function)
drivers/staging/dt3155/dt3155_drv.c:1048: error: 'IRQF_DISABLED' undeclared (first use in this function)
drivers/staging/dt3155/dt3155_drv.c:1091: error: implicit declaration of function 'free_irq'


-#ifdef MODULE
#include <linux/module.h>
#include <linux/interrupt.h>


MODULE_LICENSE("GPL");

-#endif


--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/