Prev: UIO / of_genirq driver
Next: [PATCH]PCIE AER: PCI access remove spinlock protection in aer_inject
From: Stephen Rothwell on 28 Jan 2010 02:30
Hi all,

Today's linux-next build (powerpc allnoconfig) failed like this:

ld: drivers/i2c/chips/built-in.o: No such file: No such file or directory

Caused by commit b75349f118718a435f2bb7b6e675572ecd591627 ("tsl2550: Move
form i2c/chips to als and update interfaces"). This removes the last
driver from drivers/i2c/chips/ . Maybe it needs to remove the directory
completely and the references to it from drivers/i2c as well.

I have reverted that commit for today.
--
Cheers,
Stephen Rothwell sfr(a)canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
From: Jean Delvare on 28 Jan 2010 02:50
On Thu, 28 Jan 2010 18:23:34 +1100, Stephen Rothwell wrote:
> Hi all,
>
> Today's linux-next build (powerpc allnoconfig) failed like this:
>
> ld: drivers/i2c/chips/built-in.o: No such file: No such file or directory
>
> Caused by commit b75349f118718a435f2bb7b6e675572ecd591627 ("tsl2550: Move
> form i2c/chips to als and update interfaces"). This removes the last
> driver from drivers/i2c/chips/ . Maybe it needs to remove the directory
> completely and the references to it from drivers/i2c as well.
>
> I have reverted that commit for today.

My bad. I asked Jonathan to split the directory removal from the driver
move for clarity. I didn't expect this to cause a build failure.

Jonathan, I guess that at least the drivers/i2c/Makefile part must be
moved back to the tsl2550 driver move patch. I leave it to you whether
you want to move all the rest back as well, or just that part.

Thanks Stephen for the heads up and sorry again for the breakage.

--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Jonathan Cameron on 28 Jan 2010 07:00
On 01/28/10 07:41, Jean Delvare wrote:
> On Thu, 28 Jan 2010 18:23:34 +1100, Stephen Rothwell wrote:
>> Hi all,
>>
>> Today's linux-next build (powerpc allnoconfig) failed like this:
>>
>> ld: drivers/i2c/chips/built-in.o: No such file: No such file or directory
>>
>> Caused by commit b75349f118718a435f2bb7b6e675572ecd591627 ("tsl2550: Move
>> form i2c/chips to als and update interfaces"). This removes the last
>> driver from drivers/i2c/chips/ . Maybe it needs to remove the directory
>> completely and the references to it from drivers/i2c as well.
>>
>> I have reverted that commit for today.
>
> My bad. I asked Jonathan to split the directory removal from the driver
> move for clarity. I didn't expect this to cause a build failure.
>
> Jonathan, I guess that at least the drivers/i2c/Makefile part must be
> moved back to the tsl2550 driver move patch. I leave it to you whether
> you want to move all the rest back as well, or just that part.
>
> Thanks Stephen for the heads up and sorry again for the breakage.
>
Sorry from me as well. It never occurred to me either that it might cause
a build failure.

It does make sense to keep these two steps separate. Ah well, I guess any
work around would be a pretty terrible cludge. I'll roll these two patches
back together and otherwise we will end up with something even less coherent.

Thanks,

Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Stephen Rothwell on 28 Jan 2010 07:30
Hi Jonathan, Jean,

On Thu, 28 Jan 2010 11:59:37 +0000 Jonathan Cameron <jic23(a)cam.ac.uk> wrote:
>
> It does make sense to keep these two steps separate. Ah well, I guess any
> work around would be a pretty terrible cludge. I'll roll these two patches
> back together and otherwise we will end up with something even less coherent.

OK, thanks guys.

--
Cheers,
Stephen Rothwell sfr(a)canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
From: Jonathan Cameron on 28 Jan 2010 07:40
On 01/28/10 12:17, Stephen Rothwell wrote:
> Hi Jonathan, Jean,
>
> On Thu, 28 Jan 2010 11:59:37 +0000 Jonathan Cameron <jic23(a)cam.ac.uk> wrote:
>>
>> It does make sense to keep these two steps separate. Ah well, I guess any
>> work around would be a pretty terrible cludge. I'll roll these two patches
>> back together and otherwise we will end up with something even less coherent.
>
> OK, thanks guys.
>
Everything should now be fixed in the als tree. New version of the move commit
cleans out the i2c/chips directory and changes the i2c/Makefile and i2c/Kconfig
appropriately. Only remaining related elements are the debug Kconfig option for
i2c/chips but that can definitely go through the i2c tree rather than als (if there
are no other users) and shouldn't break any builds.

Thanks,

Jonathan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 |  Next  |  Last
Pages: 1 2
Prev: UIO / of_genirq driver
Next: [PATCH]PCIE AER: PCI access remove spinlock protection in aer_inject