linux-next: build warning after merge of the ext3 tree
in [Kernel]
|
Prev: [tip:x86/mrst] x86, apbt: Moorestown APB system timer driver
Next: [patch 18/32] [PATCH] free_initmem: reduce code duplication
From: Stephen Rothwell on 24 Feb 2010 03:10 Hi Jan, After merging the ext3 tree, today's linux-next build (x86_64 allmodconfig) produced this warning: fs/gfs2/quota.c:1581: warning: initialization from incompatible pointer type Introduced by commit ec304a27d7750ba666ad2d446434ddd47fa93c40 ("quota: move code from sync_quota_sb into vfs_quota_sync"). From the commit message, I expect that this has been thought about. -- Cheers, Stephen Rothwell sfr(a)canb.auug.org.au http://www.canb.auug.org.au/~sfr/
From: Jan Kara on 24 Feb 2010 06:00 Hi Stephen, On Wed 24-02-10 19:05:20, Stephen Rothwell wrote: > After merging the ext3 tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > fs/gfs2/quota.c:1581: warning: initialization from incompatible pointer type > > Introduced by commit ec304a27d7750ba666ad2d446434ddd47fa93c40 ("quota: > move code from sync_quota_sb into vfs_quota_sync"). From the commit > message, I expect that this has been thought about. Thanks for the notification. It seems Christoph missed to convert gfs2_quota_sync(). I've now fixed it in a minimalistic way (just added the wait parameter to the function). Steven (Whitehouse), if GFS2 wants to do something more clever, please let me know (or fix up in your tree). Thanks Honza -- Jan Kara <jack(a)suse.cz> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Jan Kara on 24 Feb 2010 06:20
On Wed 24-02-10 11:58:11, Jan Kara wrote: > Hi Stephen, > > On Wed 24-02-10 19:05:20, Stephen Rothwell wrote: > > After merging the ext3 tree, today's linux-next build (x86_64 > > allmodconfig) produced this warning: > > > > fs/gfs2/quota.c:1581: warning: initialization from incompatible pointer type > > > > Introduced by commit ec304a27d7750ba666ad2d446434ddd47fa93c40 ("quota: > > move code from sync_quota_sb into vfs_quota_sync"). From the commit > > message, I expect that this has been thought about. > Thanks for the notification. It seems Christoph missed to convert > gfs2_quota_sync(). I've now fixed it in a minimalistic way (just added > the wait parameter to the function). > Steven (Whitehouse), if GFS2 wants to do something more clever, please > let me know (or fix up in your tree). And I had to fixup a few internal callers in GFS2 as well. So Steven, you might want to have a look at the patch (commit ef9eb614d974943af3c8eab8ea78a30d5132428c in my linux-fs-2.6 tree). Honza -- Jan Kara <jack(a)suse.cz> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |