Prev: (none)
Next: Where is proc_misc.c?
From: Stephen Rothwell on 19 Jan 2010 01:30
Hi Greg,

Today's linux-next build (powerpc ppc64_defconfig) produced this warning:

drivers/base/cpu.c:264: warning: initialization from incompatible pointer type
drivers/base/cpu.c:265: warning: initialization from incompatible pointer type

Introduced by commit 380567d3dc35a62f5cc0ec640a45dfc238238417 ("sysdev:
Convert node driver")?

--
Cheers,
Stephen Rothwell sfr(a)canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
From: Greg KH on 19 Jan 2010 16:20
On Tue, Jan 19, 2010 at 05:27:41PM +1100, Stephen Rothwell wrote:
> Hi Greg,
>
> Today's linux-next build (powerpc ppc64_defconfig) produced this warning:
>
> drivers/base/cpu.c:264: warning: initialization from incompatible pointer type
> drivers/base/cpu.c:265: warning: initialization from incompatible pointer type
>
> Introduced by commit 380567d3dc35a62f5cc0ec640a45dfc238238417 ("sysdev:
> Convert node driver")?

No, I don't think that patch causes the warning, I can't duplicate it
here.

I don't know what patch causes that problem, as I can't duplicate it in
my tree at all. Maybe some 'const' patch snuck in from some other tree?

strange,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Stephen Rothwell on 19 Jan 2010 18:50
Hi Greg,

On Tue, 19 Jan 2010 13:04:17 -0800 Greg KH <greg(a)kroah.com> wrote:
>
> On Tue, Jan 19, 2010 at 05:27:41PM +1100, Stephen Rothwell wrote:
> > Hi Greg,
> >
> > Today's linux-next build (powerpc ppc64_defconfig) produced this warning:
> >
> > drivers/base/cpu.c:264: warning: initialization from incompatible pointer type
> > drivers/base/cpu.c:265: warning: initialization from incompatible pointer type
> >
> > Introduced by commit 380567d3dc35a62f5cc0ec640a45dfc238238417 ("sysdev:
> > Convert node driver")?
>
> No, I don't think that patch causes the warning, I can't duplicate it
> here.
>
> I don't know what patch causes that problem, as I can't duplicate it in
> my tree at all. Maybe some 'const' patch snuck in from some other tree?
>
> strange,

OK, if it is still there today, I will look deeper.

--
Cheers,
Stephen Rothwell sfr(a)canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
From: Stephen Rothwell on 20 Jan 2010 01:30
Hi Greg,

On Wed, 20 Jan 2010 10:45:25 +1100 Stephen Rothwell <sfr(a)canb.auug.org.au> wrote:
>
> On Tue, 19 Jan 2010 13:04:17 -0800 Greg KH <greg(a)kroah.com> wrote:
> >
> > On Tue, Jan 19, 2010 at 05:27:41PM +1100, Stephen Rothwell wrote:
> > >
> > > Today's linux-next build (powerpc ppc64_defconfig) produced this warning:
> > >
> > > drivers/base/cpu.c:264: warning: initialization from incompatible pointer type
> > > drivers/base/cpu.c:265: warning: initialization from incompatible pointer type
> > >
> > > Introduced by commit 380567d3dc35a62f5cc0ec640a45dfc238238417 ("sysdev:
> > > Convert node driver")?
> >
> > No, I don't think that patch causes the warning, I can't duplicate it
> > here.
> >
> > I don't know what patch causes that problem, as I can't duplicate it in
> > my tree at all. Maybe some 'const' patch snuck in from some other tree?
> >
> > strange,
>
> OK, if it is still there today, I will look deeper.

I still get those warnings. The two referenced lines are added by the commit above. The relevant parts of the file (in the version I have) are:

(lines 98 and 99)
static CLASS_ATTR(probe, S_IWUSR, NULL, cpu_probe_store);
static CLASS_ATTR(release, S_IWUSR, NULL, cpu_release_store);

....

(lines 262-266)
static struct sysdev_class_attribute *cpu_sysdev_class_attrs[] = {
#ifdef CONFIG_ARCH_CPU_PROBE_RELEASE
&class_attr_probe.attr,
&class_attr_release.attr,
#endif


class_attr_probe.attr is a "struct attribute" not a "struct
sysdev_class_attribute".

--
Cheers,
Stephen Rothwell sfr(a)canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
From: Stephen Rothwell on 20 Jan 2010 01:50
Hi Greg,

On Wed, 20 Jan 2010 17:25:43 +1100 Stephen Rothwell <sfr(a)canb.auug.org.au> wrote:
>
> (lines 262-266)
> static struct sysdev_class_attribute *cpu_sysdev_class_attrs[] = {
> #ifdef CONFIG_ARCH_CPU_PROBE_RELEASE
> &class_attr_probe.attr,
> &class_attr_release.attr,
> #endif

The reason you may not see this is because CONFIG_ARCH_CPU_PROBE_RELEASE
is not set for x86_64 allmodconfig builds (and probably many others).

--
Cheers,
Stephen Rothwell sfr(a)canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
 |  Next  |  Last
Pages: 1 2 3
Prev: (none)
Next: Where is proc_misc.c?