Prev: 2.6.34-rc7: keyboard CAPS on/off indifferent, always capital
Next: [CLEANUP] kprobes: Remove redundant text_mutex lock in optimize
From: Thomas Gleixner on 11 May 2010 08:40
On Mon, 10 May 2010, Benjamin Herrenschmidt wrote:
>
> @@ -396,33 +406,24 @@ u64 __init __lmb_alloc_base(u64 size, u64 align, u64 max_addr)
> if (max_addr == LMB_ALLOC_ANYWHERE)
> max_addr = LMB_REAL_LIMIT;
>
> + /* Pump up max_addr */
> + if (max_addr == LMB_ALLOC_ANYWHERE)
> + max_addr = ~(u64)0;
> +

That if is pretty useless as you set max_addr to LMB_REAL_LIMIT
right above.

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Benjamin Herrenschmidt on 11 May 2010 18:30
On Tue, 2010-05-11 at 14:30 +0200, Thomas Gleixner wrote:
> > @@ -396,33 +406,24 @@ u64 __init __lmb_alloc_base(u64 size, u64
> align, u64 max_addr)
> > if (max_addr == LMB_ALLOC_ANYWHERE)
> > max_addr = LMB_REAL_LIMIT;
> >
> > + /* Pump up max_addr */
> > + if (max_addr == LMB_ALLOC_ANYWHERE)
> > + max_addr = ~(u64)0;
> > +
>
> That if is pretty useless as you set max_addr to LMB_REAL_LIMIT
> right above.

This is a mismerge/mis-rebase of one of my patches actually. I'll dbl
check what's up but I think the first hunk should go along with
LMB_REAL_LIMIT in favor of the new default limit thing. But we first
need to make sure the default is set sensibly and I haven't fixed all
archs yet.

I'll dbl check what's up there.

Cheers,
Benm.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Benjamin Herrenschmidt on 12 May 2010 01:30
On Tue, 2010-05-11 at 14:30 +0200, Thomas Gleixner wrote:
> On Mon, 10 May 2010, Benjamin Herrenschmidt wrote:
> >
> > @@ -396,33 +406,24 @@ u64 __init __lmb_alloc_base(u64 size, u64 align, u64 max_addr)
> > if (max_addr == LMB_ALLOC_ANYWHERE)
> > max_addr = LMB_REAL_LIMIT;
> >
> > + /* Pump up max_addr */
> > + if (max_addr == LMB_ALLOC_ANYWHERE)
> > + max_addr = ~(u64)0;
> > +
>
> That if is pretty useless as you set max_addr to LMB_REAL_LIMIT
> right above.

Well, actually no :-) LMB_REAL_LIMIT can actually be == to
LMB_ALLOC_ANYWHERE which at this stage in the series is still 0, so we
must not miss the second bit.

Subsequent patches remove this anyways as LMB_ALLOC_ANYWHERE gets turned
into ~0 which makes more sense.

So it's a bit weird looking, but it's correct and transitory code only.

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: 2.6.34-rc7: keyboard CAPS on/off indifferent, always capital
Next: [CLEANUP] kprobes: Remove redundant text_mutex lock in optimize