Prev: x86, lmb: Add lmb_to_bootmem()
Next: x86, lmb: Add get_free_all_memory_range()
From: Bjorn Helgaas on 29 Jun 2010 13:50
On Tuesday, June 22, 2010 11:26:32 am Yinghai Lu wrote:
> + if (lmb_debug)
> + pr_info("lmb: %s array is doubled to %ld at %llx - %llx",
> + lmb_type_name(type), type->max * 2, (u64)addr, (u64)addr + new_size);

Please print this memory range the same way we print resources, e.g.,
"%#010llx-%#010llx", with "addr" and "addr + new_size - 1".
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: H. Peter Anvin on 29 Jun 2010 14:40
On 06/29/2010 10:44 AM, Bjorn Helgaas wrote:
> On Tuesday, June 22, 2010 11:26:32 am Yinghai Lu wrote:
>> + if (lmb_debug)
>> + pr_info("lmb: %s array is doubled to %ld at %llx - %llx",
>> + lmb_type_name(type), type->max * 2, (u64)addr, (u64)addr + new_size);
>
> Please print this memory range the same way we print resources, e.g.,
> "%#010llx-%#010llx", with "addr" and "addr + new_size - 1".

*Ten* hex digits?

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Bjorn Helgaas on 29 Jun 2010 15:00
On Tuesday, June 29, 2010 12:38:44 pm H. Peter Anvin wrote:
> On 06/29/2010 10:44 AM, Bjorn Helgaas wrote:
> > On Tuesday, June 22, 2010 11:26:32 am Yinghai Lu wrote:
> >> + if (lmb_debug)
> >> + pr_info("lmb: %s array is doubled to %ld at %llx - %llx",
> >> + lmb_type_name(type), type->max * 2, (u64)addr, (u64)addr + new_size);
> >
> > Please print this memory range the same way we print resources, e.g.,
> > "%#010llx-%#010llx", with "addr" and "addr + new_size - 1".
>
> *Ten* hex digits?

I think that width includes the "0x" prefix, so it's really eight digits.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Bjorn Helgaas on 8 Jul 2010 15:00
On Sunday, July 04, 2010 12:56:07 am Yinghai Lu wrote:
> - pr_info(" %s[0x%x]\t0x%016llx - 0x%016llx, 0x%llx bytes\n",
> - name, i, base, base + size - 1, size);
> + pr_info(" %s[%#x]\t[%#016llx - %#016llx], %#llx bytes\n",
> + name, i, base, base + size, size);

I know you think it's prettier to have zeroes and extra spaces like this:

[0xe7000000 - 0xe8000000, 0x1000000 bytes]

rather than a bunch of 'F's:

[0xe7000000-0xe7ffffff]

But for the record, I still think you're wrong and that it's better
to be consistent even if it's slightly uglier. The inconsistencies
lead to confusion and off-by-one errors.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Yinghai Lu on 8 Jul 2010 16:20
On 07/08/2010 11:55 AM, Bjorn Helgaas wrote:
> On Sunday, July 04, 2010 12:56:07 am Yinghai Lu wrote:
>> - pr_info(" %s[0x%x]\t0x%016llx - 0x%016llx, 0x%llx bytes\n",
>> - name, i, base, base + size - 1, size);
>> + pr_info(" %s[%#x]\t[%#016llx - %#016llx], %#llx bytes\n",
>> + name, i, base, base + size, size);
>
> I know you think it's prettier to have zeroes and extra spaces like this:
>
> [0xe7000000 - 0xe8000000, 0x1000000 bytes]
>
> rather than a bunch of 'F's:
>
> [0xe7000000-0xe7ffffff]
>
> But for the record, I still think you're wrong and that it's better
> to be consistent even if it's slightly uglier. The inconsistencies
> lead to confusion and off-by-one errors.

We can make them to be consistent later.

current for early mem stage, it is consistent to without -1.

later I like to see all pci resource could be consistent to without -1 too.

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: x86, lmb: Add lmb_to_bootmem()
Next: x86, lmb: Add get_free_all_memory_range()