lp3971: remove unnecessary ret value checking in lp3971_i2c_write()
in [Kernel]
|
Prev: [PATCH 2/3] MEMSTICK: fix hangs on unexpected device removal in mspro_blk
Next: [PATCH 1/3] memstick: init sysfs attributes
From: Axel Lin on 5 Aug 2010 10:30 hi Mark, 2010/8/5 Mark Brown <broonie(a)opensource.wolfsonmicro.com>: > On Thu, Aug 05, 2010 at 11:40:38AM +0800, Axel Lin wrote: >> i2c_smbus_write_byte_data() returns zero or negative value, >> therefore no need to check if ret is greater than zero or not. > >> Signed-off-by: Axel Lin <axel.lin(a)gmail.com> > > Acked-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> > > but can I once more renew my request that you make some effort to > provide subject lines for your patches which are consistent with the > standard used for the area of the kernel you're submitting to? > I think we have communication problem. I thought the subject "[PATCH 1/2] lp3971: remove unnecessary ret value checking in lp3971_i2c_write()" is pretty clear. Or do you mean something else? Regards, Axel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Axel Lin on 5 Aug 2010 20:00
2010/8/5 Mark Brown <broonie(a)opensource.wolfsonmicro.com>: > On Thu, Aug 05, 2010 at 10:22:13PM +0800, Axel Lin wrote: >> 2010/8/5 Mark Brown <broonie(a)opensource.wolfsonmicro.com>: > >> > but can I once more renew my request that you make some effort to >> > provide subject lines for your patches which are consistent with the >> > standard used for the area of the kernel you're submitting to? > >> I think we have communication problem. >> I thought the subject "[PATCH 1/2] lp3971: remove unnecessary ret >> value checking in lp3971_i2c_write()" >> is pretty clear. >> Or do you mean something else? > > In this case pretty much every regulator API patch has a subject line > starting "regulator: " but none of your patches do this, you have > created your own style which you use over all your patches. > Got your point now. Will fix it next time. Thanks, Axel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |