Prev: powerpc/BSR: fix device_create() return value check
Next: [PATCH] usb/gadget: fix compile error on r8a66597-udc.c
From: Benjamin Herrenschmidt on 11 Mar 2010 16:50
On Wed, 2010-03-10 at 14:48 +1100, fthain(a)telegraphics.com.au wrote:
> On Tue, 9 Mar 2010, Michael Beardsworth wrote:
>
> > - /* If a probe is in progress or we are sleeping, wait for it to complete */
> > + /* If a probe is in progress or we are sleeping, wait until complete */
>
> If you must "fix" what aint broke, please try not to damage it. I'm sorry
> if your VT52 is limited to 80 cols, but IMNSHO this sort of effort is
> misguided.
>
> Maybe I could point out again (I do this periodically) that checkpatch.pl
> is great but code that fails it is NOT always wrong.
>
> "Check patch" is a good idea but "check existing code" is a waste of
> everyone's time.

Amen !

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: powerpc/BSR: fix device_create() return value check
Next: [PATCH] usb/gadget: fix compile error on r8a66597-udc.c