max_standby_delay considered harmful
in [PgSql]
|
Prev: Further Hot Standby documentation required
Next: [HACKERS] Streaming replication - unable to stop the standby
From: Josh Berkus on 13 May 2010 13:12 On 5/12/10 8:07 PM, Robert Haas wrote: > I think that would be a good thing to check (it'll confirm whether > this is the same bug), but I'm not convinced we should actually fix it > that way. Prior to 8.4, we handled a smart shutdown during recovery > at the conclusion of recovery, just prior to entering normal running. > I'm wondering if we shouldn't revert to that behavior in both 8.4 and > HEAD. This would be OK as long as we document it well. We patched the shutdown the way we did specifically because Fujii thought it would be an easy fix; if it's complicated, we should revert it and document the issue for DBAs. Oh, and to confirm: the same issue exists, and has always existed, with Warm Standby. -- -- Josh Berkus PostgreSQL Experts Inc. http://www.pgexperts.com -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Robert Haas on 14 May 2010 17:32 On Thu, May 13, 2010 at 1:12 PM, Josh Berkus <josh(a)agliodbs.com> wrote: > On 5/12/10 8:07 PM, Robert Haas wrote: >> I think that would be a good thing to check (it'll confirm whether >> this is the same bug), but I'm not convinced we should actually fix it >> that way. Prior to 8.4, we handled a smart shutdown during recovery >> at the conclusion of recovery, just prior to entering normal running. >> I'm wondering if we shouldn't revert to that behavior in both 8.4 and >> HEAD. > > This would be OK as long as we document it well. We patched the > shutdown the way we did specifically because Fujii thought it would be > an easy fix; if it's complicated, we should revert it and document the > issue for DBAs. I don't understand this comment. > Oh, and to confirm: the same issue exists, and has always existed, with > Warm Standby. That's what I was thinking, but I hadn't gotten around to testing it. Thanks for the confirmation. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Josh Berkus on 14 May 2010 17:51 >> This would be OK as long as we document it well. We patched the >> shutdown the way we did specifically because Fujii thought it would be >> an easy fix; if it's complicated, we should revert it and document the >> issue for DBAs. > > I don't understand this comment. In other words, I'm saying that it's not critical that we troubleshoot this for 9.0. Revering Fujii's patch, if it's not working, is an option. -- -- Josh Berkus PostgreSQL Experts Inc. http://www.pgexperts.com -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Robert Haas on 14 May 2010 18:20
On Fri, May 14, 2010 at 5:51 PM, Josh Berkus <josh(a)agliodbs.com> wrote: > >>> This would be OK as long as we document it well. We patched the >>> shutdown the way we did specifically because Fujii thought it would be >>> an easy fix; if it's complicated, we should revert it and document the >>> issue for DBAs. >> >> I don't understand this comment. > > In other words, I'm saying that it's not critical that we troubleshoot > this for 9.0. Revering Fujii's patch, if it's not working, is an option. There is no patch which we could revert to fix this, by Fujii Masao or anyone else. The patch he proposed has not been committed. I am still studying the problem to try to figure out where to go with it. We could decide to punt the whole thing for 9.1, but I'd like to understand what the options are before we make that decision. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |