Prev: [HACKERS] message style for errcontext
Next: [HACKERS] errcontext from PL/pgSQL (was message style for errcontext)
From: Tom Lane on 17 May 2010 14:31
Peter Eisentraut <peter_e(a)gmx.net> writes:
> We have in 9.0 plperl.c
> errcontext("while executing PostgreSQL::InServer::SPI::bootstrap")));
> errcontext("while parsing Perl initialization")));
> errcontext("while running Perl initialization")));
> errcontext("While executing PLC_TRUSTED.")));
> errcontext("While executing utf8fix.")));
> errcontext("While executing plperl.on_plperl_init.")));
> errcontext("while executing plperl.on_plperlu_init")));

> Could we agree on a capitalization and punctuation scheme?

Instances of errcontext() elsewhere don't use either initcap or
terminating period. I think that's probably good to stick with,
but the message guidelines need to document that these messages
shouldn't follow the "full sentence" style.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Andrew Dunstan on 17 May 2010 14:42


Peter Eisentraut wrote:
> We have in 9.0 plperl.c
>
> errcontext("while executing PostgreSQL::InServer::SPI::bootstrap")));
> errcontext("while parsing Perl initialization")));
> errcontext("while running Perl initialization")));
> errcontext("While executing PLC_TRUSTED.")));
> errcontext("While executing utf8fix.")));
> errcontext("While executing plperl.on_plperl_init.")));
> errcontext("while executing plperl.on_plperlu_init")));
>
> Could we agree on a capitalization and punctuation scheme?
>

Sure. Sorry about that. Looking at other uses it looks like the most
consistent would be to have no initial cap and no trailing period. I'll
adjust it that way if you like. Is there anything else you want adjusted?

cheers

andrew

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

 | 
Pages: 1
Prev: [HACKERS] message style for errcontext
Next: [HACKERS] errcontext from PL/pgSQL (was message style for errcontext)