mfd: MAX8998: Add interrupts support
in [Kernel]
|
Prev: [PATCH] tmio_mmc: Make ack_mmc_irqs() write-only
Next: [PATCH wq#for-next] workqueue: fix build problem on !CONFIG_SMP
From: Mark Brown on 20 Jul 2010 05:00 On Tue, Jul 20, 2010 at 03:57:37PM +0900, Joonyoung Shim wrote: > Use genirq and provide seperated file for interrupts support. > > Signed-off-by: Joonyoung Shim <jy0922.shim(a)samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park(a)samsung.com> .... > + > + for (i = 0; i < ARRAY_SIZE(max8998->irq_masks_cur); i++) { > + /* > + * If there's been a change in the mask write it back > + * to the hardware. > + */ > + if (max8998->irq_masks_cur[i] != max8998->irq_masks_cache[i]) { > + max8998->irq_masks_cache[i] = max8998->irq_masks_cur[i]; > + max8998_write_reg(max8998->i2c, MAX8998_REG_IRQM1 + i, > + max8998->irq_masks_cur[i]); > + } This code all looks oddly familiar :) Reviewed-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Joonyoung Shim on 20 Jul 2010 06:00 On 7/20/2010 5:55 PM, Mark Brown wrote: > On Tue, Jul 20, 2010 at 03:57:37PM +0900, Joonyoung Shim wrote: >> Use genirq and provide seperated file for interrupts support. >> >> Signed-off-by: Joonyoung Shim <jy0922.shim(a)samsung.com> >> Signed-off-by: Kyungmin Park <kyungmin.park(a)samsung.com> > > ... > >> + >> + for (i = 0; i < ARRAY_SIZE(max8998->irq_masks_cur); i++) { >> + /* >> + * If there's been a change in the mask write it back >> + * to the hardware. >> + */ >> + if (max8998->irq_masks_cur[i] != max8998->irq_masks_cache[i]) { >> + max8998->irq_masks_cache[i] = max8998->irq_masks_cur[i]; >> + max8998_write_reg(max8998->i2c, MAX8998_REG_IRQM1 + i, >> + max8998->irq_masks_cur[i]); >> + } > > This code all looks oddly familiar :) Yes, i didn't have any needs to use other way. > > Reviewed-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Samuel Ortiz on 25 Jul 2010 18:00
On Tue, Jul 20, 2010 at 03:57:37PM +0900, Joonyoung Shim wrote: > Use genirq and provide seperated file for interrupts support. > > Signed-off-by: Joonyoung Shim <jy0922.shim(a)samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park(a)samsung.com> Acked-by: Samuel Ortiz <sameo(a)linux.intel.com> Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |