Prev: futex: FUTEX_LOCK with optional adaptive spinning
Next: [PATCH -mm 09/12] blackfin: use use asm-generic/scatterlist.h
From: Valdis.Kletnieks on 8 Apr 2010 21:00
On Thu, 08 Apr 2010 17:36:07 +0200, Patrick McHardy said:

> Valdis.Kletnieks(a)vt.edu wrote:

> > Well, it *changed* it. Does the rcu_defererence_check() only fire on the
> > first time it hits something, so we've fixed the first one and now we get to
> > see the second one?
>
> It appears that way, otherwise you should have seen a second warning in
> nf_conntrack_ecache the last time.
>
> > (For what it's worth, if this is going to be one-at-a-time whack-a-mole, I'm
> > OK on that, just want to know up front.)
>
> I went through the other files and I believe this should be it.
> We already removed most of these incorrect rcu_dereference()
> calls a while back.

Confirming - the second version of the patch fixes all the network-related
RCU complaints I've been able to trigger...
From: Patrick McHardy on 9 Apr 2010 10:50
Valdis.Kletnieks(a)vt.edu wrote:
> On Thu, 08 Apr 2010 17:36:07 +0200, Patrick McHardy said:
>
>> Valdis.Kletnieks(a)vt.edu wrote:
>
>>> Well, it *changed* it. Does the rcu_defererence_check() only fire on the
>>> first time it hits something, so we've fixed the first one and now we get to
>>> see the second one?
>> It appears that way, otherwise you should have seen a second warning in
>> nf_conntrack_ecache the last time.
>>
>>> (For what it's worth, if this is going to be one-at-a-time whack-a-mole, I'm
>>> OK on that, just want to know up front.)
>> I went through the other files and I believe this should be it.
>> We already removed most of these incorrect rcu_dereference()
>> calls a while back.
>
> Confirming - the second version of the patch fixes all the network-related
> RCU complaints I've been able to trigger...

Thanks. I've added the attached commit to the nf-next tree. I'll push
it to Dave shortly so this can get included in the next tree.

First  |  Prev  | 
Pages: 1 2
Prev: futex: FUTEX_LOCK with optional adaptive spinning
Next: [PATCH -mm 09/12] blackfin: use use asm-generic/scatterlist.h