mpt2sas: Fix &&/|| confusion in _scsih_sas_device_status_change_event()
in [Kernel]
|
Prev: hid: Logitech G13 driver 0.0.3
Next: mpt2sas: Fix &&/|| confusion in _scsih_sas_device_status_change_event()
From: roel kluin on 7 Jan 2010 15:00 On Thu, Jan 7, 2010 at 8:31 PM, Moore, Eric <Eric.Moore(a)lsi.com> wrote: > nack > > The code beyond this check is intended for either INTERNAL_DEVICE_RESET or CMP_DEVICE_RESET. If the reason code is something else, we will want to return. There are 10 other types of reason codes besides these two. This proposed patch means we return only when the reason code is either INTERNAL_DEVICE_RESET or CMP_INTERNAL_RESET. > > Eric Moore my patch is correct but my changelog was wrong. Sorry for the confusion. It should have been: Even if the ReasonCode is not INTERNAL_DEVICE_RESET nor CMP_DEVICE_RESET this still evaluates to true. you can test this with: #include <stdio.h> int main() { int d; for (d=0;d<4;++d) printf("!(%d == 1 && %d == 2) = %d\n", d, d, !(d == 1 && d == 2)); for (d=0;d<4;++d) printf("!(%d == 1 || %d == 2) = %d\n", d, d, !(d == 1 || d == 2)); return 0; } Roel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |