Prev: msi-laptop: Add threeg sysfs file for support query 3G state by standard 66/62 ec command
Next: [PATCH 30/36] serial: timberdale: Remove dependancies
From: Greg KH on 2 Mar 2010 18:50
On Tue, Mar 02, 2010 at 11:39:29PM +0000, Matthew Garrett wrote:
> On Tue, Mar 02, 2010 at 03:28:57PM -0800, Greg Kroah-Hartman wrote:
> > From: Lee, Chun-Yi <jlee(a)novell.com>
> >
> > Some MSI 3G netbook only have one fn key to control Wlan/Bluetooth/3G,
> > those netbook will load the SCM (windows app) to disable the original
> > Wlan/Bluetooth control by BIOS when user press fn key, then control
> > Wlan/Bluetooth/3G by SCM (software control by OS). Without SCM, user
> > cann't on/off 3G module on those 3G netbook.
> > On Linux, msi-laptop driver will do the same thing to disable the
> > original BIOS control, then might need use HAL or other userland
> > application to do the software control that simulate with SCM.
> > e.g. MSI N034 netbook
>
> How does the function key event get reported to userland? This should
> generate KEY_RFKILL and then just go through rfkill-input.

I'm pretty sure that Joey is using rfkill here, but I didn't realize
that it also supported an input device.

This code is just detecting the keypress, and acting on it, I think,
right Joey? Isn't that the way this is supposed to work? Or is it
supposed to use rfkill-input, which then userspace turns around and
calls the other rfkill interface to then disable the wireless? If so, I
think a number of laptop drivers need to be changed to do this.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 9 Mar 2010 16:20
On Tue, Mar 09, 2010 at 05:42:58AM -0700, Joey Lee wrote:
> Hi Greg,
>
> Please kindly review the attached patch for removed the non-standard
> interface "threeg" in msi-laptop driver.

Looks good to me.

Matthew, are you going to be taking patches like this now?

If so, feel free to add:
Acked-by: Greg Kroah-Hartman <gregkh(a)suse.de>
to the patch.

If not, please let me know.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: msi-laptop: Add threeg sysfs file for support query 3G state by standard 66/62 ec command
Next: [PATCH 30/36] serial: timberdale: Remove dependancies