net: VMware virtual Ethernet NIC driver: vmxnet3
in [Kernel]
|
Prev: hard lockup, followed by ext4_lookup: deleted inode referenced: 524788
Next: WARNING: at net/ipv4/af_inet.c:154 inet_sock_destruct
From: David Miller on 28 Sep 2009 20:10 From: Shreyas Bhatewara <sbhatewara(a)vmware.com> Date: Mon, 28 Sep 2009 16:56:45 -0700 > + uint32_t rxdIdx:12; /* Index of the RxDesc */ Don't use uint32_t et al. sized types, use "u32" and friends throughout. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 28 Sep 2009 20:30 On Mon, Sep 28, 2009 at 04:56:45PM -0700, Shreyas Bhatewara wrote: > Ethernet NIC driver for VMware's vmxnet3 > > From: Shreyas Bhatewara <sbhatewara(a)vmware.com> > > This patch adds driver support for VMware's virtual Ethernet NIC : vmxnet3 > Guests running on VMware hypervisors supporting vmxnet3 device will thus > have access to improved network functionalities and performance. > > Signed-off-by: Shreyas Bhatewara <sbhatewara(a)vmware.com> I thought this was going to be submitted for the drivers/staging/ tree. What happened? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Shreyas Bhatewara on 29 Sep 2009 12:40 > -----Original Message----- > From: David Miller [mailto:davem(a)davemloft.net] > Sent: Monday, September 28, 2009 5:08 PM > To: Shreyas Bhatewara > Cc: linux-kernel(a)vger.kernel.org; netdev(a)vger.kernel.org; > shemminger(a)linux-foundation.org; jgarzik(a)pobox.com; > anthony(a)codemonkey.ws; chrisw(a)sous-sol.org; greg(a)kroah.com; akpm(a)linux- > foundation.org; virtualization(a)lists.linux-foundation.org; pv- > drivers(a)vmware.com > Subject: Re: [PATCH 2.6.31-rc9] net: VMware virtual Ethernet NIC > driver: vmxnet3 > > From: Shreyas Bhatewara <sbhatewara(a)vmware.com> > Date: Mon, 28 Sep 2009 16:56:45 -0700 > > > + uint32_t rxdIdx:12; /* Index of the RxDesc */ > > Don't use uint32_t et al. sized types, use "u32" and friends > throughout. Sure, I will fix that. ->Shreyas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Stephen Hemminger on 30 Sep 2009 20:40 On Wed, 30 Sep 2009 14:34:57 -0700 (PDT) Shreyas Bhatewara <sbhatewara(a)vmware.com> wrote: Note: your patch was linewrapped again > + > + > +static void > +vmxnet3_declare_features(struct vmxnet3_adapter *adapter, bool dma64) > +{ > + struct net_device *netdev = adapter->netdev; > + > + netdev->features = NETIF_F_SG | > + NETIF_F_HW_CSUM | > + NETIF_F_HW_VLAN_TX | > + NETIF_F_HW_VLAN_RX | > + NETIF_F_HW_VLAN_FILTER | > + NETIF_F_TSO | > + NETIF_F_TSO6; > + > + printk(KERN_INFO "features: sg csum vlan jf tso tsoIPv6"); > + > + adapter->rxcsum = true; > + adapter->jumbo_frame = true; > + > + if (!disable_lro) { > + adapter->lro = true; > + printk(" lro"); > + } Why not use NETIF_F_LRO and ethtool to control LRO support? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Shreyas Bhatewara on 30 Sep 2009 21:20
Stephen, Thanks for taking a look. > -----Original Message----- > From: Stephen Hemminger [mailto:shemminger(a)vyatta.com] > Sent: Wednesday, September 30, 2009 5:39 PM > To: Shreyas Bhatewara > Cc: linux-kernel; netdev; Stephen Hemminger; David S. Miller; Jeff > Garzik; Anthony Liguori; Chris Wright; Greg Kroah-Hartman; Andrew > Morton; virtualization; pv-drivers > Subject: Re: [PATCH 2.6.32-rc1] net: VMware virtual Ethernet NIC > driver: vmxnet3 > > On Wed, 30 Sep 2009 14:34:57 -0700 (PDT) > Shreyas Bhatewara <sbhatewara(a)vmware.com> wrote: > > Note: your patch was linewrapped again > Fixed the alpine option. Should not happen again. > > + > > + > > +static void > > +vmxnet3_declare_features(struct vmxnet3_adapter *adapter, bool > dma64) > > +{ > > + struct net_device *netdev = adapter->netdev; > > + > > + netdev->features = NETIF_F_SG | > > + NETIF_F_HW_CSUM | > > + NETIF_F_HW_VLAN_TX | > > + NETIF_F_HW_VLAN_RX | > > + NETIF_F_HW_VLAN_FILTER | > > + NETIF_F_TSO | > > + NETIF_F_TSO6; > > + > > + printk(KERN_INFO "features: sg csum vlan jf tso tsoIPv6"); > > + > > + adapter->rxcsum = true; > > + adapter->jumbo_frame = true; > > + > > + if (!disable_lro) { > > + adapter->lro = true; > > + printk(" lro"); > > + } > > Why not use NETIF_F_LRO and ethtool to control LRO support? Yes, that would be a better way to do it. I will make that change. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |