Prev: [GIT PULL] first round of vhost-net enhancements for net-next
Next: KEYS: Fix an RCU warning in the reading of user keys
From: Ben Hutchings on 3 May 2010 17:50
On Tue, 2010-05-04 at 00:24 +0300, Michael S. Tsirkin wrote:
> When debugging faulty hardware (in case of virt, faulty
> emulation) I found it helpful to be able to examine
> stopped status of the interface. The following patch makes
> this visible in sysfs.
[...]

This is a per-queue attribute and should not be associated directly with
the netdev.

Ben.

--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: David Miller on 3 May 2010 18:10
From: "Michael S. Tsirkin" <mst(a)redhat.com>
Date: Tue, 4 May 2010 00:24:25 +0300

> @@ -303,6 +313,7 @@ static struct device_attribute net_class_attributes[] = {
> __ATTR(address, S_IRUGO, show_address, NULL),
> __ATTR(broadcast, S_IRUGO, show_broadcast, NULL),
> __ATTR(carrier, S_IRUGO, show_carrier, NULL),
> + __ATTR(carrier, S_IRUGO, show_stopped, NULL),

Besides the fact that you have to publish this as a per-queue attribute,
you're also erroneously naming it 'carrier' here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [GIT PULL] first round of vhost-net enhancements for net-next
Next: KEYS: Fix an RCU warning in the reading of user keys