niu: always include of_device.h
in [Kernel]
|
Prev: of_device.h: provide struct of_device even when not enabled
Next: [tip:x86/cpu] x86, AMD: Extend support to future families
From: Grant Likely on 9 Jun 2010 19:50 On Wed, Jun 9, 2010 at 4:44 PM, Randy Dunlap <randy.dunlap(a)oracle.com> wrote: > From: Randy Dunlap <randy.dunlap(a)oracle.com> > > The niu driver uses struct of_device when built on any arch, not > only SPARC64, so always #include <linux/of_device.h>. > > drivers/net/niu.c:9700: warning: 'struct of_device' declared inside parameter list > drivers/net/niu.c:9700: warning: its scope is only this definition or declaration, which is probably not what you want > drivers/net/niu.c:9716: warning: assignment from incompatible pointer type > > Signed-off-by: Randy Dunlap <randy.dunlap(a)oracle.com> > Cc: � � Grant Likely <grant.likely(a)secretlab.ca> > Cc: � � Dave Miller <davem(a)davemloft.net> > --- > �drivers/net/niu.c | � �3 --- Looks okay to me (but I haven't build tested it yet). The bulk of of_device.h is compiled out when CONFIG_OF_DEVICE is not selected. David, are you okay with me taking this via my tree as it depends on Randy's other patch? Thanks, g. > �1 file changed, 3 deletions(-) > > --- linux-next-20100609.orig/drivers/net/niu.c > +++ linux-next-20100609/drivers/net/niu.c > @@ -28,10 +28,7 @@ > �#include <linux/slab.h> > > �#include <linux/io.h> > - > -#ifdef CONFIG_SPARC64 > �#include <linux/of_device.h> > -#endif > > �#include "niu.h" > > -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: David Miller on 9 Jun 2010 20:30
From: Grant Likely <grant.likely(a)secretlab.ca> Date: Wed, 9 Jun 2010 17:45:54 -0600 > On Wed, Jun 9, 2010 at 4:44 PM, Randy Dunlap <randy.dunlap(a)oracle.com> wrote: >> From: Randy Dunlap <randy.dunlap(a)oracle.com> >> >> The niu driver uses struct of_device when built on any arch, not >> only SPARC64, so always #include <linux/of_device.h>. >> >> drivers/net/niu.c:9700: warning: 'struct of_device' declared inside parameter list >> drivers/net/niu.c:9700: warning: its scope is only this definition or declaration, which is probably not what you want >> drivers/net/niu.c:9716: warning: assignment from incompatible pointer type >> >> Signed-off-by: Randy Dunlap <randy.dunlap(a)oracle.com> >> Cc: � � Grant Likely <grant.likely(a)secretlab.ca> >> Cc: � � Dave Miller <davem(a)davemloft.net> >> --- >> �drivers/net/niu.c | � �3 --- > > Looks okay to me (but I haven't build tested it yet). The bulk of > of_device.h is compiled out when CONFIG_OF_DEVICE is not selected. > > David, are you okay with me taking this via my tree as it depends on > Randy's other patch? Yep, that's totally fine with me: Acked-by: David S. Miller <davem(a)davemloft.net> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |