Prev: powerpc/mcu_mpc8349emitx: Remove OF GPIO handling stuff
Next: gpiolib: Introduce chip addition/removal notifier
From: David Brownell on 26 Jan 2010 01:50
On Monday 25 January 2010, Anton Vorontsov wrote:
> With this patch there are two ways to register OF GPIO controllers:
>
> 1. Allocating the of_gpio_chip structure and passing the
> � �&of_gc->gc pointer to the gpiochip_add. (Can use container_of
> � �to convert the gpio_chip to the of_gpio_chip.)
>
> 2. Allocating and registering the gpio_chip structure separately
> � �from the of_gpio_chip. (Since two allocations are separate,
> � �container_of won't work.)
>
> As time goes by we'll kill the first option.

Why have two options, instead of just the first/simpler one??

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: David Brownell on 26 Jan 2010 16:10
On Tuesday 26 January 2010, Anton Vorontsov wrote:
>
> > Why have two options, instead of just the first/simpler one??
>
> Because I2C/SPI drivers allocate (and register) gpio_chip structures
> by themselves, so the first option is a no-go.

You should be mentioning such issues in the patch comments.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: powerpc/mcu_mpc8349emitx: Remove OF GPIO handling stuff
Next: gpiolib: Introduce chip addition/removal notifier