+ oom-sacrifice-child-with-highest-badness-score-for-parent-protect-dereferencing-of-tasks-comm.patch added to -mm tree
in [Kernel]
|
Prev: [PATCH 7/9] oom: remove child->mm check from oom_kill_process()
Next: [PATCH] x86: OLPC: add support for calling into OpenFirmware (v4)
From: KOSAKI Motohiro on 16 Jun 2010 22:00 > > The patch titled > oom: protect dereferencing of task's comm > has been added to the -mm tree. Its filename is > oom-sacrifice-child-with-highest-badness-score-for-parent-protect-dereferencing-of-tasks-comm.patch > > Before you just go and hit "reply", please: > a) Consider who else should be cc'ed > b) Prefer to cc a suitable mailing list as well > c) Ideally: find the original patch on the mailing list and do a > reply-to-all to that, adding suitable additional cc's > > *** Remember to use Documentation/SubmitChecklist when testing your code *** > > See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find > out what to do about this > > The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ > > ------------------------------------------------------ > Subject: oom: protect dereferencing of task's comm > From: David Rientjes <rientjes(a)google.com> > > Andrew notes that dereferencing task->comm is unsafe without holding > task_lock(task). That's true even when dealing with current, so all > existing dereferences within the oom killer need to ensure they are > holding task_lock() before doing so. > > This avoids using get_task_comm() because we'd otherwise need to allocate > a string of TASK_COMM_LEN on the stack (or add synchronization and use a > global string) and we don't want to do that because page allocations, and > thus the oom killer, can happen particularly deep in the stack. > > Reported-by: Andrew Morton <akpm(a)linux-foundation.org> > Signed-off-by: David Rientjes <rientjes(a)google.com> > Cc: KOSAKI Motohiro <kosaki.motohiro(a)jp.fujitsu.com> > Cc: Balbir Singh <balbir(a)in.ibm.com> > Cc: Oleg Nesterov <oleg(a)redhat.com> > Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> Acked-by: KOSAKI Motohiro <kosaki.motohiro(a)jp.fujitsu.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |