Prev: oom: introduce find_lock_task_mm() to fix !mm false positives
Next: linux-next: build failure after merge of the shtree
From: KOSAKI Motohiro on 31 May 2010 21:20
Hi

> > --- a/mm/oom_kill.c
> > +++ b/mm/oom_kill.c
> > @@ -287,7 +287,7 @@ static struct task_struct *select_bad_process(unsigned long *ppoints,
> > * the process of exiting and releasing its resources.
> > * Otherwise we could get an easy OOM deadlock.
> > */
> > - if (p->flags & PF_EXITING) {
> > + if ((p->flags & PF_EXITING) && p->mm) {
>
> (strictly speaking, this change is needed after 3/5 which removes the
> top-level "if (!p->mm)" check in select_bad_process).
>
>
> I'd like to add a note... with or without this, we have problems
> with the coredump. A thread participating in the coredumping
> (group-leader in this case) can have PF_EXITING && mm, but this doesn't
> mean it is going to exit soon, and the dumper can use a lot more memory.

Sure. I think coredump sould do nothing if oom occur.
So, merely making PF_COREDUMP is bad idea? I mean


task-flags allocator
------------------------------------------------
none N/A
TIF_MEMDIE allow to use emergency memory.
don't call page reclaim.
PF_COREDUMP N/A
TIF_MEMDIE+PF_COREDUMP disallow to use emergency memory.
don't call page reclaim.

In other word, coredump path makes allocation failure if the task
marked as TIF_MEMDIE.
And, userland oom helper should be marked PF_OOM_ORIGIN perhaps.


> Otoh, if select_bad_process() chooses the thread which dumps the core,
> SIGKILL can't stop it. This should be fixed in do_coredump() paths, this
> is the long-standing problem.
>
> And, as it was already discussed, we only check the group-leader here.
> But I can't suggest something better.

I guess signal_group_exit() is enough in practical case. I mean
exit(2) is only used by pthread_exit(3), so practically the last thread
in the process don't die by using exit(2).

I don't say signal_group_exit() is no side-effect. but I guess originally
intention was testing during _process_ exiting.

Am I missing something?



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: oom: introduce find_lock_task_mm() to fix !mm false positives
Next: linux-next: build failure after merge of the shtree