partitions: fix build error in ibm partition detection code
in [Kernel]
|
Prev: [PATCH 2.6.35] NFSv4: Don't do idmapper upcalls during XDR decode
Next: [PATCH] x86: fpu xstate fix memory poison overwritten
From: Heiko Carstens on 12 Aug 2010 06:50 On Thu, Aug 12, 2010 at 10:53:38AM +0200, Andreas Schwab wrote: > Heiko Carstens <heiko.carstens(a)de.ibm.com> writes: > > > - strlcat(tmp, sizeof(tmp), "(nonl)", PAGE_SIZE); > > + snprintf(tmp, sizeof(tmp), "(nonl)"); > > + strlcat(state->pp_buf, tmp, PAGE_SIZE); > > What's the point of tmp and snprintf if it just creates a copy of a > constant string? > > strlcat(state->pp_buf, "(nonl)", PAGE_SIZE); There's no point, just followed the pattern in the original patch without thinking. Thanks! Updated patch: Subject: [PATCH] partitions: fix build error in ibm partition detection code From: Heiko Carstens <heiko.carstens(a)de.ibm.com> 9c867fbe "partitions: fix sometimes unreadable partition strings" coverted one line within the ibm partition code incorrectly. Fix this to get rid of a build error. fs/partitions/ibm.c: In function 'ibm_partition': [...] fs/partitions/ibm.c:185: error: too many arguments to function 'strlcat' Cc: Alexey Dobriyan <adobriyan(a)gmail.com> Signed-off-by: Heiko Carstens <heiko.carstens(a)de.ibm.com> --- fs/partitions/ibm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/partitions/ibm.c +++ b/fs/partitions/ibm.c @@ -182,7 +182,7 @@ int ibm_partition(struct parsed_partitio offset = (info->label_block + 1); } else { /* unlabeled disk */ - strlcat(tmp, sizeof(tmp), "(nonl)", PAGE_SIZE); + strlcat(state->pp_buf, "(nonl)", PAGE_SIZE); size = i_size >> 9; offset = (info->label_block + 1); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |