Prev: [patch 121/164] wrong type for magic argument in simple_fill_super()
Next: [patch 092/164] signals: check_kill_permission(): dont check creds if same_thread_group()
From: Greg KH on 1 Jul 2010 17:00
2.6.33-stable review patch. If anyone has any objections, please let me know.

------------------

From: Jeff Moyer <jmoyer(a)redhat.com>

commit 91803b499cca2fe558abad709ce83dc896b80950 upstream.

I/O errors can happen due to temporary failures, like multipath
errors or losing network contact with the iSCSI server. Because
of that, the VM will retry readpage on the page.

However, do_generic_file_read does not clear PG_error. This
causes the system to be unable to actually use the data in the
page cache page, even if the subsequent readpage completes
successfully!

The function filemap_fault has had a ClearPageError before
readpage forever. This patch simply adds the same to
do_generic_file_read.

Signed-off-by: Jeff Moyer <jmoyer(a)redhat.com>
Signed-off-by: Rik van Riel <riel(a)redhat.com>
Acked-by: Larry Woodman <lwoodman(a)redhat.com>
Signed-off-by: Linus Torvalds <torvalds(a)linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh(a)suse.de>

---
mm/filemap.c | 6 ++++++
1 file changed, 6 insertions(+)

--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -1099,6 +1099,12 @@ page_not_up_to_date_locked:
}

readpage:
+ /*
+ * A previous I/O error may have been due to temporary
+ * failures, eg. multipath errors.
+ * PG_error will be set again if readpage fails.
+ */
+ ClearPageError(page);
/* Start the actual read. The read will unlock the page. */
error = mapping->a_ops->readpage(filp, page);



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [patch 121/164] wrong type for magic argument in simple_fill_super()
Next: [patch 092/164] signals: check_kill_permission(): dont check creds if same_thread_group()