Prev: [patch 130/164] GFS2: Fix permissions checking for setflags ioctl()
Next: [patch 149/164] x86, paravirt: Add a global synchronization point for pvclock
From: Greg KH on 1 Jul 2010 17:10
2.6.33-stable review patch. If anyone has any objections, please let me know.

------------------

From: Theodore Ts'o <tytso(a)mit.edu>

commit 1f5a81e41f8b1a782c68d3843e9ec1bfaadf7d72 upstream.

Dan Roseberg has reported a problem with the MOVE_EXT ioctl. If the
donor file is an append-only file, we should not allow the operation
to proceed, lest we end up overwriting the contents of an append-only
file.

Signed-off-by: "Theodore Ts'o" <tytso(a)mit.edu>
Cc: Dan Rosenberg <dan.j.rosenberg(a)gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh(a)suse.de>

---
fs/ext4/move_extent.c | 3 +++
1 file changed, 3 insertions(+)

--- a/fs/ext4/move_extent.c
+++ b/fs/ext4/move_extent.c
@@ -964,6 +964,9 @@ mext_check_arguments(struct inode *orig_
return -EINVAL;
}

+ if (IS_IMMUTABLE(donor_inode) || IS_APPEND(donor_inode))
+ return -EPERM;
+
/* Ext4 move extent does not support swapfile */
if (IS_SWAPFILE(orig_inode) || IS_SWAPFILE(donor_inode)) {
ext4_debug("ext4 move extent: The argument files should "


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [patch 130/164] GFS2: Fix permissions checking for setflags ioctl()
Next: [patch 149/164] x86, paravirt: Add a global synchronization point for pvclock