Prev: Latest git build failure on s390 - dma_get_cache_alignment()
Next: [RFC] [PATCH 1/4] hugetlb: prepare exclusion control functions for hugepage
From: Dan Carpenter on 12 Aug 2010 04:00
copy_to_user() returns the number of bytes remaining but we want to
return a negative error code on errors.

Signed-off-by: Dan Carpenter <error27(a)gmail.com>

diff --git a/drivers/char/ip2/ip2main.c b/drivers/char/ip2/ip2main.c
index 8fa041e..d4b71e8 100644
--- a/drivers/char/ip2/ip2main.c
+++ b/drivers/char/ip2/ip2main.c
@@ -2930,6 +2930,8 @@ ip2_ipl_ioctl (struct file *pFile, UINT cmd, ULONG arg )
if ( pCh )
{
rc = copy_to_user(argp, pCh, sizeof(i2ChanStr));
+ if (rc)
+ rc = -EFAULT;
} else {
rc = -ENODEV;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: Latest git build failure on s390 - dma_get_cache_alignment()
Next: [RFC] [PATCH 1/4] hugetlb: prepare exclusion control functions for hugepage