Prev: [PATCH 1/2] char: add WARN_ON() in misc_deregister()
Next: [RFC PATCH 0/1] input/touchscreen: Synaptics Touchscreen Driver
From: Rafael J. Wysocki on 30 May 2010 17:00
On Sunday 30 May 2010, mark gross wrote:
> On Sun, May 30, 2010 at 09:50:01PM +0200, Rafael J. Wysocki wrote:
> > On Sunday 30 May 2010, Nigel Cunningham wrote:
> > > Hi.
> > >
> > > On 30/05/10 06:08, Rafael J. Wysocki wrote:
> > > > On Saturday 29 May 2010, mark gross wrote:
> > > >> The following patch is to help clean up API abusers of pm_qos where
> > > >> they call update_request before registering a request.
> > > >>
> > > >> --mgross
> > > >>
> > > >> --Signed-off-by: markgross<markgross(a)thegnar.org>
> > > >
> > > > Will there be a big issue if I push this during the next merge window?
> > >
> > > What's the point to the patch? That is: why is calling update_request
> > > before registering a request such a big problem that it demands a WARN()
> > > and dump stack?
> >
> > It is an API violation if I understand that correctly.
>
> Yeah, it is, but now that I'm thinking clearly perhaps a better fix
> would be to change the prototype of pm_qos_update_request to return
> something so callers can check for success.
>
> Lets fix the API rather than use this patch. Please dopt apply it.

OK

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
First  |  Prev  | 
Pages: 1 2
Prev: [PATCH 1/2] char: add WARN_ON() in misc_deregister()
Next: [RFC PATCH 0/1] input/touchscreen: Synaptics Touchscreen Driver