Prev: nilfs2: Remove an uninitialization warning in nilfs_btree_propagate_v()
Next: [patch v3] infiniband: ulp/iser, fix error retval in iser_create_ib_conn_res
From: Dan Carpenter on 2 Apr 2010 07:40
Return -EINVAL if we don't find the right query control id.

Signed-off-by: Dan Carpenter <error27(a)gmail.com>

diff --git a/drivers/media/video/cx88/cx88-video.c b/drivers/media/video/cx88/cx88-video.c
index 48c450f..b4c80cb 100644
--- a/drivers/media/video/cx88/cx88-video.c
+++ b/drivers/media/video/cx88/cx88-video.c
@@ -1537,9 +1537,12 @@ static int radio_queryctrl (struct file *file, void *priv,
c->id >= V4L2_CID_LASTP1)
return -EINVAL;
if (c->id == V4L2_CID_AUDIO_MUTE) {
- for (i = 0; i < CX8800_CTLS; i++)
+ for (i = 0; i < CX8800_CTLS; i++) {
if (cx8800_ctls[i].v.id == c->id)
break;
+ }
+ if (i == CX8800_CTLS)
+ return -EINVAL;
*c = cx8800_ctls[i].v;
} else
*c = no_ctl;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: nilfs2: Remove an uninitialization warning in nilfs_btree_propagate_v()
Next: [patch v3] infiniband: ulp/iser, fix error retval in iser_create_ib_conn_res