Prev: [patch] hdpuftrs: use resource_size()
Next: [patch] pxa168fb: use resource_size()
From: Dan Carpenter on 22 Mar 2010 08:20
I'm pretty sure that it should be + 1 here. It's an off by one, because
we start counting at zero.

Signed-off-by: Dan Carpenter <error27(a)gmail.com>
---
Found by a static checker and untested. Please review carefully.

diff --git a/drivers/mfd/timberdale.h b/drivers/mfd/timberdale.h
index 8d27ffa..902c451 100644
--- a/drivers/mfd/timberdale.h
+++ b/drivers/mfd/timberdale.h
@@ -66,7 +66,7 @@

#define CHIPCTLOFFSET 0x800
#define CHIPCTLEND 0x8ff
-#define CHIPCTLSIZE (CHIPCTLEND - CHIPCTLOFFSET)
+#define CHIPCTLSIZE (CHIPCTLEND - CHIPCTLOFFSET + 1)

#define INTCOFFSET 0xc00
#define INTCEND 0xfff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [patch] hdpuftrs: use resource_size()
Next: [patch] pxa168fb: use resource_size()