perf: Add third parameter to symbol_filter_t.
in [Kernel]
|
Prev: [PATCH 3/3] powerpc: Dont require a dma_ops struct to set dma mask
Next: [PATCH 2/2] [TRIVIAL] fix grammar by adding a missing "to" in the comments
From: Arnaldo Carvalho de Melo on 5 Aug 2010 11:20 Em Tue, Jul 27, 2010 at 04:41:19PM +0530, Srikar Dronamraju escreveu: > GElf_Sym for a symbol is needed to filter out based on binding, > type, value. This will be needed to list only global binding > functions when listing functions from perf probe. Humm, I think it is better to store the symbol binding in struct symbol, so that we can have the full symtab and then, on a particular routine, decide wheter we should use it or not. I'll cook up a patch now. - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Arnaldo Carvalho de Melo on 5 Aug 2010 11:30 Em Thu, Aug 05, 2010 at 12:19:30PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Jul 27, 2010 at 04:41:19PM +0530, Srikar Dronamraju escreveu: > > GElf_Sym for a symbol is needed to filter out based on binding, > > type, value. This will be needed to list only global binding > > functions when listing functions from perf probe. > > Humm, I think it is better to store the symbol binding in struct symbol, > so that we can have the full symtab and then, on a particular routine, > decide wheter we should use it or not. One extra reason is that when we read the symtab from kallsyms, we don't have a GElf_Sym to pass to the filter. > I'll cook up a patch now. > > - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Srikar Dronamraju on 5 Aug 2010 11:30
> Em Tue, Jul 27, 2010 at 04:41:19PM +0530, Srikar Dronamraju escreveu: > > GElf_Sym for a symbol is needed to filter out based on binding, > > type, value. This will be needed to list only global binding > > functions when listing functions from perf probe. > > Humm, I think it is better to store the symbol binding in struct symbol, > so that we can have the full symtab and then, on a particular routine, > decide wheter we should use it or not. > > I'll cook up a patch now. Okay, Please keep me in loop on that patch so that I can update this patch accordingly. -- Thanks and Regards Srikar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |