perf: Round robin groups of events using list_rotate_left()
in [Kernel]
|
Prev: perf: Round robin groups of events using list_rotate_left()
Next: [PATCH 1/3] Fix minor spelling error in comments
From: Frederic Weisbecker on 14 Jan 2010 07:30 On Thu, Jan 14, 2010 at 01:25:22PM +0100, Peter Zijlstra wrote: > On Sun, 2010-01-10 at 02:38 +0100, Frederic Weisbecker wrote: > > This is more proper that doing it through a list_for_each_entry() > > that breaks after the first entry. > > > > Signed-off-by: Frederic Weisbecker <fweisbec(a)gmail.com> > > Cc: Peter Zijlstra <peterz(a)infradead.org> > > Cc: Arnaldo Carvalho de Melo <acme(a)redhat.com> > > Cc: Paul Mackerras <paulus(a)samba.org> > > --- > > > + list_rotate_left(&ctx->pinned_groups); > > + list_rotate_left(&ctx->flexible_groups); > > Just wondering, pinned events were supposed to be on the pmu at all > times, right? Yeah, but the previous version that was using a global list rotated the whole. So, somehow to keep the same bahaviour, I also rotate the pinned group, even if it makes no sense :-) But there is a subsequent patch in the same set that removes the rotating of pinned groups. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |