Prev: cfq-iosced: Implement IOPS mode and group_idle tunable V3
Next: [BUGFIX][PATCH] Fix false positive BUG_ON in __page_set_anon_rmap
From: Gleb Natapov on 22 Jul 2010 03:30
The script below demonstrate this. The problem is in
hist_entry__parse_objdump_line():

if (*tmp) {
/*
* Parse hexa addresses followed by ':'
*/
line_ip = strtoull(tmp, &tmp2, 16);
if (*tmp2 != ':' || tmp == tmp2)
line_ip = -1;
}

strtoull() returns valid number when it gets line with label and following
test passes too. I can't think of a way to unambiguously distinguish between
label and valid rip. May be running objdump with --prefix-addresses will
help, but it may make other thing unambiguous.

=== script ===
cat > test.c << EOF
int main(int argc, char **argv)
{
int i;

while(1) {
i++;
if (i == 10000000)
goto add;
}
add:
return 0;
}
EOF

gcc -g test.c
perf record ./a.out
perf annotate
--
Gleb.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: cfq-iosced: Implement IOPS mode and group_idle tunable V3
Next: [BUGFIX][PATCH] Fix false positive BUG_ON in __page_set_anon_rmap