Prev: [RFC/PATCH] platform_bus: allow custom extensions to system PM methods
Next: platform_bus: allow custom extensions to system PM methods
From: Stephane Eranian on 23 Mar 2010 18:50 On Tue, Mar 23, 2010 at 4:18 PM, Peter Zijlstra <peterz(a)infradead.org> wrote: > On Tue, 2010-03-23 at 16:12 +0100, Stephane Eranian wrote: >> On Tue, Mar 23, 2010 at 4:07 PM, Peter Zijlstra <peterz(a)infradead.org> wrote: >> > On Tue, 2010-03-23 at 15:55 +0100, Stephane Eranian wrote: >> >> What's the point of CPU_ONLINE vs. CPU_STARTING if you're saying the >> >> former is never right? Why not move CPU_ONLINE to the right place and >> >> drop CPU_STARTING? >> > >> > Its right for a lot of things, just not for perf, we need to be ready >> > and done by the time the cpu starts scheduling. >> > >> You mean they need to wait until after the cpu starts scheduling? >> As opposed to being called just before it starts scheduling. > > As in it doesn't really matter for them, and the CPU_ONLINE call is > convenient in that it allows the callback to schedule too. > Fine, I will try your proposed patch tomorrow. A priori, it looks fine. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |