perf: export tracepoint events via sysfs: iwlwifi and iwlwifi_io
in [Kernel]
|
Prev: [RFC][PATCH v1 01/15] perf: core, add functions to export events via sysfs
Next: perf: export tracepoint events via sysfs: mac80211
From: Johannes Berg on 22 Jul 2010 07:30 On Thu, 2010-07-22 at 19:13 +0800, Lin Ming wrote: > iwlwifi and iwlwifi_io tracepoint events are exported like below, > drivers/net/wireless/iwlwifi/iwl3945-base.c | 15 +++++++++++++++ > 1 files changed, 15 insertions(+), 0 deletions(-) err, how about iwlagn? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Steven Rostedt on 22 Jul 2010 09:40 On Thu, 2010-07-22 at 13:20 +0200, Johannes Berg wrote: > On Thu, 2010-07-22 at 19:13 +0800, Lin Ming wrote: > > iwlwifi and iwlwifi_io tracepoint events are exported like below, > > > drivers/net/wireless/iwlwifi/iwl3945-base.c | 15 +++++++++++++++ > > 1 files changed, 15 insertions(+), 0 deletions(-) > > err, how about iwlagn? A lot of work went into making the include/trace/events/*.h be able to automate the work. Now it seems that we are going to hand code a lot, and a developer that adds a new system or such will now need to understand the internals of perf to use it. That was what I strived to avoid when creating the TRACE_EVENT() macros. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Steven Rostedt on 22 Jul 2010 10:00 On Thu, 2010-07-22 at 15:48 +0200, Ingo Molnar wrote: > * Steven Rostedt <rostedt(a)goodmis.org> wrote: > Yeah - and the point of this submission is to allow the discussion of how to > achieve these registrations. > > Driver authors will want to have some control - for example the place where > the events directory shows up in sysfs within the driver's directory structure > - etc. > > But we indeed want to automate it as much as possible. Perhaps we can create a TRACE_EVENT_PATH() macro, that allows the developer to specify the path that the event will be seen in sysfs? -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Lin Ming on 22 Jul 2010 21:00 On Thu, 2010-07-22 at 19:20 +0800, Johannes Berg wrote: > On Thu, 2010-07-22 at 19:13 +0800, Lin Ming wrote: > > iwlwifi and iwlwifi_io tracepoint events are exported like below, > > > drivers/net/wireless/iwlwifi/iwl3945-base.c | 15 +++++++++++++++ > > 1 files changed, 15 insertions(+), 0 deletions(-) > > err, how about iwlagn? Will add this. > > johannes > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Dave Chinner on 22 Jul 2010 21:40
On Thu, Jul 22, 2010 at 09:54:04AM -0400, Steven Rostedt wrote: > On Thu, 2010-07-22 at 15:48 +0200, Ingo Molnar wrote: > > * Steven Rostedt <rostedt(a)goodmis.org> wrote: > > > Yeah - and the point of this submission is to allow the discussion of how to > > achieve these registrations. > > > > Driver authors will want to have some control - for example the place where > > the events directory shows up in sysfs within the driver's directory structure > > - etc. > > > > But we indeed want to automate it as much as possible. > > Perhaps we can create a TRACE_EVENT_PATH() macro, that allows the > developer to specify the path that the event will be seen in sysfs? Perhaps you could build that into the event class definition as well so each separate class in a subsystem can be placed in it's own sub-directory? That would make turning on and off specific classes trace points so much simpler than it now, espcially for XFS where we now have > 250 tracepoints that are mostly defined by event classes already... Cheers, Dave. -- Dave Chinner david(a)fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |