pg_migrator issues
in [PgSql]
|
From: Tom Lane on 7 Jan 2010 00:32 Peter Eisentraut <peter_e(a)gmx.net> writes: > On mån, 2010-01-04 at 13:07 -0500, Bruce Momjian wrote: >> Yea, I am not excited about having vacuumdb do only analyze, but it >> seems the most minimal solution. I spelled it --only-analyze and just >> posted the reason and patch. > I can't find the patch and the reason, but note that we already have > other options like --data-only, --schema-only, --tuples-only. I > personally don't like the spelling of --only-analyze. In particular note that pg_dump has options --schema and --schema-only, and nobody has complained about that. I concur with Peter that this spelling is gratuitously unlike everyplace else. Perhaps we could compromise by calling it "--no-vacuum", instead? regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Bruce Momjian on 7 Jan 2010 07:12 Tom Lane wrote: > Peter Eisentraut <peter_e(a)gmx.net> writes: > > On mån, 2010-01-04 at 13:07 -0500, Bruce Momjian wrote: > >> Yea, I am not excited about having vacuumdb do only analyze, but it > >> seems the most minimal solution. I spelled it --only-analyze and just > >> posted the reason and patch. > > > I can't find the patch and the reason, but note that we already have > > other options like --data-only, --schema-only, --tuples-only. I > > personally don't like the spelling of --only-analyze. > > In particular note that pg_dump has options --schema and --schema-only, > and nobody has complained about that. I concur with Peter that this > spelling is gratuitously unlike everyplace else. Oh, interesting about pg_dump. Let's just go with --analyze-only. --only-analyze is feeling odd to me too. -- Bruce Momjian <bruce(a)momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Bruce Momjian on 7 Jan 2010 07:40 > Tom Lane wrote: > > Peter Eisentraut <peter_e(a)gmx.net> writes: > > > On m<C3><A5>n, 2010-01-04 at 13:07 -0500, Bruce Momjian wrote: > > >> Yea, I am not excited about having vacuumdb do only analyze, but it > > >> seems the most minimal solution. I spelled it --only-analyze and just > > >> posted the reason and patch. > > > > > I can't find the patch and the reason, but note that we already have > > > other options like --data-only, --schema-only, --tuples-only. I > > > personally don't like the spelling of --only-analyze. > > > > In particular note that pg_dump has options --schema and --schema-only, > > and nobody has complained about that. I concur with Peter that this > > spelling is gratuitously unlike everyplace else. > > Oh, interesting about pg_dump. Let's just go with --analyze-only. > --only-analyze is feeling odd to me too. Done, attached and applied. -- Bruce Momjian <bruce(a)momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. +
From: Alvaro Herrera on 7 Jan 2010 09:06 Bruce Momjian escribi�: > > Oh, interesting about pg_dump. Let's just go with --analyze-only. > > --only-analyze is feeling odd to me too. > > Done, attached and applied. <bikeshedding> Why -o and not, say, -Z? I imagine you picked -o for "only" but it seems strange. </> -- Alvaro Herrera http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Bruce Momjian on 7 Jan 2010 09:35
Alvaro Herrera wrote: > Bruce Momjian escribi?: > > > > Oh, interesting about pg_dump. Let's just go with --analyze-only. > > > --only-analyze is feeling odd to me too. > > > > Done, attached and applied. > > <bikeshedding> > Why -o and not, say, -Z? I imagine you picked -o for "only" but it > seems strange. > </> Hmmm, sure -Z makes sense. Change applied with attached patch. Thanks. -- Bruce Momjian <bruce(a)momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + |