From: Bruce Momjian on
Tom Lane wrote:
> Alvaro Herrera <alvherre(a)alvh.no-ip.org> writes:
> > Excerpts from Bruce Momjian's message of jue may 06 11:19:27 -0400 2010:
> >> It seems copying over pg_statistic would require preservation of
> >> pg_class.oid. Right now we only preserve pg_class.relfilenode.
>
> > That could be fixed easily by creating a throwaway table which included the
> > qualified table name instead of the OID, and reloading it into pg_statistic
> > after the migration.
>
> Yeah. Casting to and from regclass would do the trick too.

I will add this idea to the pg_migrator TODO file. I didn't bother with
this in the 8.3 -> 8.4 migration because we changed the default number
of statistics collected in 8.4.

This would be a 9.1 item.

--
Bruce Momjian <bruce(a)momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Bruce Momjian on
Bruce Momjian wrote:
> Tom Lane wrote:
> > "Joshua D. Drake" <jd(a)commandprompt.com> writes:
> > > On Wed, 2010-05-05 at 20:24 -0400, Robert Haas wrote:
> > >> I think it will be confusing if we change the name, so I vote to not
> > >> change the name.
> >
> > > Actually, I would vote yes to change the name.
> >
> > I lean that way too. If there were no history involved, we'd certainly
> > prefer pg_upgrade to pg_migrator.
>
> Yeah, that was my feeling too. People like "pg_upgrade", or something
> else? I will add some text like "pg_upgrade (formerly pg_migrator)" in
> the docs.

OK, seems people like pg_upgrade, but do we call it "pgupgrade" or
"pg_upgrade"? I don't see consistent naming in /contrib:

pg_buffercache/
pg_freespacemap/
pg_standby/
pg_stat_statements/
pg_trgm/
pgbench/
pgcrypto/
pgrowlocks/
pgstattuple/

The original 7.2 name was "pg_upgrade":

http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/contrib/pg_upgrade/Attic/

--
Bruce Momjian <bruce(a)momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Thom Brown on
On 6 May 2010 20:55, Bruce Momjian <bruce(a)momjian.us> wrote:

> Bruce Momjian wrote:
> > Tom Lane wrote:
> > > "Joshua D. Drake" <jd(a)commandprompt.com> writes:
> > > > On Wed, 2010-05-05 at 20:24 -0400, Robert Haas wrote:
> > > >> I think it will be confusing if we change the name, so I vote to not
> > > >> change the name.
> > >
> > > > Actually, I would vote yes to change the name.
> > >
> > > I lean that way too. If there were no history involved, we'd certainly
> > > prefer pg_upgrade to pg_migrator.
> >
> > Yeah, that was my feeling too. People like "pg_upgrade", or something
> > else? I will add some text like "pg_upgrade (formerly pg_migrator)" in
> > the docs.
>
> OK, seems people like pg_upgrade, but do we call it "pgupgrade" or
> "pg_upgrade"? I don't see consistent naming in /contrib:
>
> pg_buffercache/
> pg_freespacemap/
> pg_standby/
> pg_stat_statements/
> pg_trgm/
> pgbench/
> pgcrypto/
> pgrowlocks/
> pgstattuple/
>
> The original 7.2 name was "pg_upgrade":
>
>
> http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/contrib/pg_upgrade/Attic/
>
> --
>
>
You will call it pg_upgrade. I have spoken.

Thom
From: Tom Lane on
Bruce Momjian <bruce(a)momjian.us> writes:
> OK, seems people like pg_upgrade, but do we call it "pgupgrade" or
> "pg_upgrade"?

The latter. The former is unreadable.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Dave Page on
On Thu, May 6, 2010 at 8:10 PM, Thom Brown <thombrown(a)gmail.com> wrote:

> You will call it pg_upgrade.  I have spoken.
> Thom

LOL.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers