pg_stat_transaction patch
in [PgSql]
|
Prev: [HACKERS] WIP patch: pass outer-relation Vars as parameters to indexscans
Next: [HACKERS] CommitFest 2010-07 Plans and Call for Reviewers
From: Itagaki Takahiro on 12 Jul 2010 05:36 "Accessor functions to get so far collected statistics for the current transaction" https://commitfest.postgresql.org/action/patch_view?id=301 The latest version of the patch works as expected, and also well-formed. I'll mark the patch to "Ready for Committer". http://archives.postgresql.org/message-id/AANLkTikSYdRwATGAP5U6O6zwIO4b_WNJXIbUd2y2tI01(a)mail.gmail.com The added views and functions only accumulates activity counters in the same transaction where the stat views are queried. So we need to check the view before COMMIT or ROLLBACK. The only issue in the patch is too long view and function names: - pg_stat_transaction_user_tables (31 chars) - pg_stat_get_transaction_tuples_hot_updated (42 chars) - pg_stat_get_transaction_function_self_time (42 chars) Since we've already used _xact_ in some system objects, we could replace _transaction_ parts with _xact_. It will save 7 key types per query ;-) -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Magnus Hagander on 12 Jul 2010 06:03
On Mon, Jul 12, 2010 at 11:36, Itagaki Takahiro <itagaki.takahiro(a)gmail.com> wrote: > "Accessor functions to get so far collected statistics for the current > transaction" > https://commitfest.postgresql.org/action/patch_view?id=301 > > The latest version of the patch works as expected, and also well-formed. > I'll mark the patch to "Ready for Committer". > http://archives.postgresql.org/message-id/AANLkTikSYdRwATGAP5U6O6zwIO4b_WNJXIbUd2y2tI01(a)mail.gmail.com > > The added views and functions only accumulates activity counters > in the same transaction where the stat views are queried. So we > need to check the view before COMMIT or ROLLBACK. > > The only issue in the patch is too long view and function names: > �- pg_stat_transaction_user_tables (31 chars) > �- pg_stat_get_transaction_tuples_hot_updated (42 chars) > �- pg_stat_get_transaction_function_self_time (42 chars) > > Since we've already used _xact_ in some system objects, we could replace > _transaction_ parts with _xact_. It will save 7 key types per query ;-) +1 on shortening that down, they're scary long now :-) -- �Magnus Hagander �Me: http://www.hagander.net/ �Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |