pg_upgrade code questions
in [PgSql]
|
Prev: Stefan's bug (was: max_standby_delay considered harmful)
Next: How to know killed by pg_terminate_backend
From: Devrim =?ISO-8859-1?Q?G=DCND=DCZ?= on 13 May 2010 02:22 On Thu, 2010-05-13 at 15:13 +0900, Takahiro Itagaki wrote: > ==== 4. EDB_NATIVE_LANG ==== > Of course it is commented out with #ifdef, but do we have codes > for EDB in core? I was about to raise similar thing, for the documentation: http://developer.postgresql.org/pgdocs/postgres/pgupgrade.html This includes some references to EDB AS, which should be removed from PostgreSQL official documentation, IMHO. Regards, -- Devrim GÃNDÃZ PostgreSQL DanıÅmanı/Consultant, Red Hat Certified Engineer PostgreSQL RPM Repository: http://yum.pgrpms.org Community: devrim~PostgreSQL.org, devrim.gunduz~linux.org.tr http://www.gunduz.org Twitter: http://twitter.com/devrimgunduz
From: Magnus Hagander on 13 May 2010 06:12 On Thu, May 13, 2010 at 8:22 AM, Devrim GÜNDÜZ <devrim(a)gunduz.org> wrote: > On Thu, 2010-05-13 at 15:13 +0900, Takahiro Itagaki wrote: >> ==== 4. EDB_NATIVE_LANG ==== >> Of course it is commented out with #ifdef, but do we have codes >> for EDB in core? > > I was about to raise similar thing, for the documentation: > > http://developer.postgresql.org/pgdocs/postgres/pgupgrade.html > > This includes some references to EDB AS, which should be removed from > PostgreSQL official documentation, IMHO. +1 on getting rid of those references. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Bruce Momjian on 13 May 2010 11:06 Magnus Hagander wrote: > On Thu, May 13, 2010 at 8:22 AM, Devrim G?ND?Z <devrim(a)gunduz.org> wrote: > > On Thu, 2010-05-13 at 15:13 +0900, Takahiro Itagaki wrote: > >> ==== 4. EDB_NATIVE_LANG ==== > >> Of course it is commented out with #ifdef, but do we have codes > >> for EDB in core? > > > > I was about to raise similar thing, for the documentation: > > > > http://developer.postgresql.org/pgdocs/postgres/pgupgrade.html > > > > This includes some references to EDB AS, which should be removed from > > PostgreSQL official documentation, IMHO. > > +1 on getting rid of those references. Agreed. When it was on pgFoundry, I had to mention that because it was unclear who would be using it, but in /contrib we know this is for community Postgres. EnterpriseDB did contribute the code so I would like to keep the code working for EnterpriseDB Advanced Server if that is easy. I have added SGML comments to comment out the text that mentions EDB Advanced Server. Is that enough? Should I remove the text from the SGML? Should I move it to the bottom of the SGML? Should I remove the EnterpriseDB Advanced Server checks from the C code too? I don't remember having to deal with anything like this before, so I am unclear how to proceed. -- Bruce Momjian <bruce(a)momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Magnus Hagander on 13 May 2010 11:19 On Thu, May 13, 2010 at 5:06 PM, Bruce Momjian <bruce(a)momjian.us> wrote: > Magnus Hagander wrote: >> On Thu, May 13, 2010 at 8:22 AM, Devrim G?ND?Z <devrim(a)gunduz.org> wrote: >> > On Thu, 2010-05-13 at 15:13 +0900, Takahiro Itagaki wrote: >> >> ==== 4. EDB_NATIVE_LANG ==== >> >> Of course it is commented out with #ifdef, but do we have codes >> >> for EDB in core? >> > >> > I was about to raise similar thing, for the documentation: >> > >> > http://developer.postgresql.org/pgdocs/postgres/pgupgrade.html >> > >> > This includes some references to EDB AS, which should be removed from >> > PostgreSQL official documentation, IMHO. >> >> +1 on getting rid of those references. > > Agreed. When it was on pgFoundry, I had to mention that because it was > unclear who would be using it, but in /contrib we know this is for > community Postgres. EnterpriseDB did contribute the code so I would > like to keep the code working for EnterpriseDB Advanced Server if that > is easy. > > I have added SGML comments to comment out the text that mentions EDB > Advanced Server. Is that enough? Should I remove the text from the > SGML? Should I move it to the bottom of the SGML? Should I remove the > EnterpriseDB Advanced Server checks from the C code too? I don't > remember having to deal with anything like this before, so I am unclear > how to proceed. I say remove it. On all accounts. There's a fork of postgres for EDB AS, shouldn't there be a fork of pg_upgrade the same way, if it requires special code? The code in community postgresql certainly shouldn't have any EDB AS code in it. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Tom Lane on 13 May 2010 11:37 Magnus Hagander <magnus(a)hagander.net> writes: > On Thu, May 13, 2010 at 5:06 PM, Bruce Momjian <bruce(a)momjian.us> wrote: >> I have added SGML comments to comment out the text that mentions EDB >> Advanced Server. �Is that enough? �Should I remove the text from the >> SGML? �Should I move it to the bottom of the SGML? �Should I remove the >> EnterpriseDB Advanced Server checks from the C code too? �I don't >> remember having to deal with anything like this before, so I am unclear >> how to proceed. > I say remove it. On all accounts. > There's a fork of postgres for EDB AS, shouldn't there be a fork of > pg_upgrade the same way, if it requires special code? The code in > community postgresql certainly shouldn't have any EDB AS code in it. Indeed. Given the (presumably large) delta between EDB's code and ours, having to have some delta in pg_upgrade isn't going to make much difference for them. I think the community code and docs should completely omit any mention of that. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
|
Next
|
Last
Pages: 1 2 3 4 Prev: Stefan's bug (was: max_standby_delay considered harmful) Next: How to know killed by pg_terminate_backend |